make sure to give MEMBER OF the correct precedence (#18237)

Signed-off-by: Andres Taylor <[email protected]>

Author: systay

go/vt/sqlparser/parse_test.go

@@ -42,6 +42,8 @@ var (
 		partialDDL           bool
 		ignoreNormalizerTest bool
 	}{{
+		input: "select a and b member of (c) from dual",
+	}, {
 		input: "select * from foo limit 5 + 5",
 	}, {
 		input:  "create table x(location GEOMETRYCOLLECTION DEFAULT (POINT(7.0, 3.0)))",

go/vt/sqlparser/precedence.go

@@ -56,9 +56,7 @@ func precedenceFor(in Expr) Precendence {
 		return P13
 	case *BetweenExpr:
 		return P12
-	case *ComparisonExpr:
-		return P11
-	case *IsExpr:
+	case *ComparisonExpr, *IsExpr, *MemberOfExpr:
 		return P11
 	case *BinaryExpr:
 		switch node.Operator {

go/vt/sqlparser/precedence_test.go

@@ -21,6 +21,8 @@ import (
 	"testing"
 	"time"
 
+	"github.com/stretchr/testify/assert"
+
 	"github.com/stretchr/testify/require"
 )
 
@@ -161,6 +163,11 @@ func TestParens(t *testing.T) {
 		{in: "(~ (1||0)) IS NULL", expected: "~(1 or 0) is null"},
 		{in: "1 not like ('a' is null)", expected: "1 not like ('a' is null)"},
 		{in: ":vtg1 not like (:vtg2 is null)", expected: ":vtg1 not like (:vtg2 is null)"},
+		{in: "a and b member of (c)", expected: "a and b member of (c)"},
+		{
+			in:       "foo is null and (bar = true or cast('1448364' as unsigned) member of (baz))",
+			expected: "foo is null and (bar = true or cast('1448364' as unsigned) member of (baz))",
+		},
 	}
 
 	parser := NewTestParser()
@@ -196,3 +203,25 @@ func TestRandom(t *testing.T) {
 		require.Equal(t, outputOfParseResult, inputQ)
 	}
 }
+
+func TestPrecedenceOfMemberOfWithAndWithoutParser(t *testing.T) {
+	// This test was used to expose the difference in precedence between the parser and the ast formatter
+	expression := "a and b member of (c)"
+
+	// hand coded ast with the expected precedence
+	ast1 := &AndExpr{
+		Left: NewColName("a"),
+		Right: &MemberOfExpr{
+			Value:   NewColName("b"),
+			JSONArr: NewColName("c"),
+		},
+	}
+
+	assert.Equal(t, expression, String(ast1))
+
+	// Now let's try it through the parser
+	ast2, err := NewTestParser().ParseExpr(expression)
+	require.NoError(t, err)
+
+	assert.Equal(t, expression, String(ast2))
+}