Skip to content

Commit 087bdbb

Browse files
Remove onlineddl_vrepl_test which was added
Signed-off-by: siddharth16396 <[email protected]>
1 parent 7ff83c6 commit 087bdbb

File tree

1 file changed

+0
-37
lines changed

1 file changed

+0
-37
lines changed

go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go

Lines changed: 0 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -358,43 +358,6 @@ func TestVreplSchemaChanges(t *testing.T) {
358358
onlineddl.CheckCancelMigration(t, &vtParams, shards, uuid, false)
359359
onlineddl.CheckRetryMigration(t, &vtParams, shards, uuid, false)
360360
})
361-
362-
t.Run("successful online alter, postponed, vtgate, with shards", func(t *testing.T) {
363-
insertRows(t, 2)
364-
uuid := testOnlineDDLStatement(t, alterTableTrivialStatement, "vitess -postpone-completion", providedUUID, providedMigrationContext, "vtgate", "test_val", "", false)
365-
// Should be still running!
366-
_ = onlineddl.WaitForMigrationStatus(t, &vtParams, shards, uuid, extendedMigrationWait, schema.OnlineDDLStatusRunning)
367-
onlineddl.CheckMigrationStatus(t, &vtParams, shards, uuid, schema.OnlineDDLStatusRunning)
368-
369-
// Try to complete with irrelevant shards (should fail)
370-
onlineddl.CheckCompleteMigrationShards(t, &vtParams, shards, uuid, "x,y,z", false)
371-
// Migration should still be running
372-
onlineddl.CheckMigrationStatus(t, &vtParams, shards, uuid, schema.OnlineDDLStatusRunning)
373-
374-
// Issue a complete with a relevant shard and wait for successful completion.
375-
onlineddl.CheckCompleteMigrationShards(t, &vtParams, shards[0:1], uuid, "-80", true)
376-
{
377-
status := onlineddl.WaitForMigrationStatus(t, &vtParams, shards[:1], uuid, extendedMigrationWait, schema.OnlineDDLStatusComplete, schema.OnlineDDLStatusFailed)
378-
fmt.Printf("# Migration status (for debug purposes): <%s>\n", status)
379-
// Shard which is passed as args will have state complete.
380-
onlineddl.CheckMigrationStatus(t, &vtParams, shards[:1], uuid, schema.OnlineDDLStatusComplete)
381-
}
382-
{
383-
status := onlineddl.WaitForMigrationStatus(t, &vtParams, shards[1:], uuid, extendedMigrationWait, schema.OnlineDDLStatusQueued, schema.OnlineDDLStatusReady, schema.OnlineDDLStatusRunning, schema.OnlineDDLStatusFailed)
384-
fmt.Printf("# Migration status (for debug purposes): <%s>\n", status)
385-
// Shard which is not passed as args will still have status queued,ready or running.
386-
onlineddl.CheckMigrationStatus(t, &vtParams, shards[1:], uuid, schema.OnlineDDLStatusQueued, schema.OnlineDDLStatusReady, schema.OnlineDDLStatusRunning)
387-
}
388-
389-
testRows(t)
390-
testMigrationRowCount(t, uuid)
391-
// schema change for shard "-80" is completed so it can't be cancelled or retried.
392-
// schema change for shard "80-" is not completed so it can be cancelled or retried.
393-
onlineddl.CheckCancelMigration(t, &vtParams, shards[1:], uuid, true)
394-
onlineddl.CheckRetryMigration(t, &vtParams, shards[1:], uuid, true)
395-
396-
onlineddl.CheckCancelAllMigrations(t, &vtParams, -1)
397-
})
398361
// Notes about throttling:
399362
// In this endtoend test we test both direct tablet API for throttling, as well as VTGate queries.
400363
// - VTGate queries (`ALTER VITESS_MIGRATION THROTTLE ALL ...`) are sent to all relevant shards/tablets via QueryExecutor

0 commit comments

Comments
 (0)