Update structure of carousel component to be A11y compatible #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you, will get it released tomorrow. |
Contributor
Author
|
Hello @santoshyadavdev , Thank you for merging. Thx. |
Member
|
Hey @thomasnisole, Will do it today 😊, thank you for the PR again. |
Member
|
Available in 3.0.2 please try and let us know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello all,
My pull request is about accessibility. Your carousel is not compatible with the order applied by browsers during keyboard navigation.
PR only modifies the previous button placement to have a more logical navigation.
Thx,
Thomas.