xx-go: zig support #214
xx-go: zig support #214
Conversation
src/xx-go
Outdated
| if command -v "$XX_TRIPLE-pkg-config" >/dev/null 2>/dev/null; then | ||
| export PKG_CONFIG="$XX_TRIPLE-pkg-config" | ||
| pkgconfig_set=1 | ||
| if command -v "zig" >/dev/null 2>/dev/null; then |
There was a problem hiding this comment.
I'm not sure we should replace CC with zig just because it is installed. I guess this would be ok if there is no clang and gcc installed. Otherwise I would expect some opt-in env.
There was a problem hiding this comment.
Added XX_GO_PREFER_COMPILER as opt-in to use zig (defaults to clang if not set)
Yes will add tests
Hum yes might make sense for |
I will look at these as follow-up if that's fine to you |
src/test-go.bats
Outdated
| skip "Zig not supported" | ||
| fi | ||
| export CGO_ENABLED=1 | ||
| export XX_GO_PREFER_COMPILER=zig |
src/xx-info
Outdated
| echo "XX_PKG_ARCH=${XX_PKG_ARCH}" | ||
| fi | ||
| echo "XX_TRIPLE=${XX_TRIPLE}" | ||
| echo "XX_ZIG_TRIPLE=${XX_ZIG_TRIPLE}" |
There was a problem hiding this comment.
it is a bit weird to expose this in xx-info directly I think. We don't do this for other compilers with similar custom names. Maybe we should leave it to xx-go helper function for now and if we ever add xx-zig we can add smth like --print-target-triple there.
Signed-off-by: CrazyMax <[email protected]>
2 participants
cc @rumpl