[FrameworkBundle] acces public-deprecated services via the private container to remove false-positive deprecations

Author: nicolas-grekas

DependencyInjection/AddConsoleCommandPass.php

@@ -29,12 +29,14 @@ class AddConsoleCommandPass implements CompilerPassInterface
     private $commandLoaderServiceId;
     private $commandTag;
     private $noPreloadTag;
+    private $privateTagName;
 
-    public function __construct(string $commandLoaderServiceId = 'console.command_loader', string $commandTag = 'console.command', string $noPreloadTag = 'container.no_preload')
+    public function __construct(string $commandLoaderServiceId = 'console.command_loader', string $commandTag = 'console.command', string $noPreloadTag = 'container.no_preload', string $privateTagName = 'container.private')
     {
         $this->commandLoaderServiceId = $commandLoaderServiceId;
         $this->commandTag = $commandTag;
         $this->noPreloadTag = $noPreloadTag;
+        $this->privateTagName = $privateTagName;
     }
 
     public function process(ContainerBuilder $container)
@@ -62,7 +64,7 @@ public function process(ContainerBuilder $container)
             }
 
             if (null === $commandName) {
-                if (!$definition->isPublic() || $definition->isPrivate()) {
+                if (!$definition->isPublic() || $definition->isPrivate() || $definition->hasTag($this->privateTagName)) {
                     $commandId = 'console.command.public_alias.'.$id;
                     $container->setAlias($commandId, $id)->setPublic(true);
                     $id = $commandId;