address comments

Author: pgrayy

src/strands/models/gemini.py

@@ -43,7 +43,7 @@ class GeminiConfig(TypedDict, total=False):
         """
 
         model_id: Required[str]
-        params: Optional[dict[str, Any]]
+        params: dict[str, Any]
 
     def __init__(
         self,
@@ -183,9 +183,9 @@ def _format_request_tools(self, tool_specs: Optional[list[ToolSpec]]) -> list[ge
             genai.types.Tool(
                 function_declarations=[
                     genai.types.FunctionDeclaration(
-                        name=tool_spec["name"],
                         description=tool_spec["description"],
-                        parameters=tool_spec["inputSchema"]["json"],
+                        name=tool_spec["name"],
+                        parameters_json_schema=tool_spec["inputSchema"]["json"],
                     )
                     for tool_spec in tool_specs or []
                 ],

tests/strands/models/test_gemini.py

@@ -34,6 +34,15 @@ def messages():
     return [{"role": "user", "content": [{"text": "test"}]}]
 
 
+@pytest.fixture
+def tool_spec():
+    return {
+        "description": "description",
+        "name": "name",
+        "inputSchema": {"json": {"key": "val"}},
+    }
+
+
 @pytest.fixture
 def system_prompt():
     return "s1"
@@ -211,6 +220,30 @@ async def test_stream_request_with_reasoning(gemini_client, model, model_id):
     gemini_client.aio.models.generate_content_stream.assert_called_with(**exp_request)
 
 
+@pytest.mark.asyncio
+async def test_stream_request_with_tool_spec(gemini_client, model, model_id, tool_spec):
+    await anext(model.stream([], [tool_spec]))
+
+    exp_request = {
+        "config": {
+            "tools": [
+                {
+                    "function_declarations": [
+                        {
+                            "description": "description",
+                            "name": "name",
+                            "parameters_json_schema": {"key": "val"},
+                        },
+                    ],
+                },
+            ],
+        },
+        "contents": [],
+        "model": model_id,
+    }
+    gemini_client.aio.models.generate_content_stream.assert_called_with(**exp_request)
+
+
 @pytest.mark.asyncio
 async def test_stream_request_with_tool_use(gemini_client, model, model_id):
     messages = [