transactionId support for SetChargingProfile (i.e. TxProfile support for ChargingProfilePurpose) #1816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to test TxProfile we need the possibility to specify the necessary transaction id. This small hack adds a simple text input field and some simple checks for the transaction id. This is not the best solution but still better than before.
In case the charge point doesn't known the charging profile that should be cleared, it might be already done. So remove the profile regardless of the reply status from the repository to be in sync.
Instead of keeping track which TxProfile belongs to which transaction, exclude the temporary TxProfiles from the profile repository completely.
…er-for-txprofile # Conflicts: # src/main/java/de/rwth/idsg/steve/ocpp/task/ClearChargingProfileTask.java # src/main/java/de/rwth/idsg/steve/ocpp/task/SetChargingProfileTask.java # src/main/java/de/rwth/idsg/steve/service/ChargePointService16_Client.java
goekay
force-pushed
the
367-chargingprofilepurpose-missing-parameter-for-txprofile
branch
from
e2988d2 to
c8e49c1
Compare
Member
Author
|
@lategoodbye please take a look. |
goekay
changed the title
Contributor
|
LGTM |
goekay
deleted the
367-chargingprofilepurpose-missing-parameter-for-txprofile
branch
juherr
added a commit
to juherr/evolve
that referenced
this pull request
Sep 15, 2025
… and transaction IDs Backport of steve-community#1809 and steve-community#1816
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR addresses an issue (i.e. missing feature) mentioned by the following issues:
this PR brings the changes from here.