Improve query functionality #1682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reason: swagger UI cannot infer the proper schema, if there are overlapping inner classes with the same name, such as: - OcppTagQueryForm.ForApi - TransactionQueryForm.ForApi
Contributor
|
@goekay Fyi about the 2nd commit, using |
Member
Author
|
thanks, i stumbled upon that as well, but found it less robust. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1st commit adds a new functionality in terms of a new field to query by.
2nd commit addresses an annoyance and confusion when using swagger. apparently, another solution is setting the property
springdoc.use-fqn=true. but then the class name uses the complete package name, which can be considered an unnecessary leak of impl detail.