JP-3887: Add photometric time dependence tables

[melanieclarke]

Partially resolves JP-3887

Corresponding jwst PR is: spacetelescope/jwst#9736

This PR adds time dependence coefficient tables to all photom models, except MirMrsPhotomModel, which already has time coefficient extensions that need a different form from the others. MirImgPhotomModel also had a time coefficients table, but needs to move to the new format to allow more flexibility.

3 optional tables are added to each model: timecoeff_linear, timecoeff_exponential, and timecoeff_powerlaw. Any, all, or none may be present, and the photom code will compose the correction from the appropriate functional forms.

I also added some validation code for all photom models (except MIRI MRS) to verify that if present, the timecoeff extensions match the phot_table rows.

Tasks

• update or add relevant tests
• update relevant docstrings and / or docs/ page
• Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
  • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
  • run jwst regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")

news fragment change types...

• changes/<PR#>.feature.rst: new feature
• changes/<PR#>.bugfix.rst: fixes an issue
• changes/<PR#>.doc.rst: documentation change
• changes/<PR#>.removal.rst: deprecation or removal of public API
• changes/<PR#>.misc.rst: infrastructure or miscellaneous change

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.14%. Comparing base (76e5e14) to head (1ab79ec).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #555      +/-   ##
==========================================
+ Coverage   90.10%   90.14%   +0.04%     
==========================================
  Files         110      110              
  Lines        5317     5339      +22     
==========================================
+ Hits         4791     4813      +22     
  Misses        526      526              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[melanieclarke]

Regression tests here with spacetelescope/jwst#9736:
https://github.com/spacetelescope/RegressionTests/actions/runs/16892547832

Tests show one very small change to the background level value for one input file. This appears to be precision related, from minor changes to the way the time dependence is calculated for MIRI imaging photom corrections: the background level fit in skymatch is sensitive to very small changes in the data. There is otherwise no impact to the output data.

Downstream jwst tests are failing because the tests attempt to access the old "timecoeff" extension directly in a MIRI imaging photom model, so merging this PR will need to be coordinated with the jwst PR.

[melanieclarke]

Rerunning regression tests after adding MIRI MRS changes:
https://github.com/spacetelescope/RegressionTests/actions/runs/17137431976

[emolter]

All my questions have been answered but I'd feel more comfortable if this had a second reviewer. I guess that'd be @tapastro in this case

[tapastro]

Looks good, with one suggestion on validation.

[tapastro]

This is probably an unlikely case, but I think a model with no phot_table extension would pass validation due to it failing this if statement. If we're going to attempt validation, it probably needs an explicit check for the phot_table before this?

[melanieclarke]

Sure, I can add that. I thought about adding that check and decided to allow an empty photom file, since only the check on the time coeff tables was requested. But you're right that it's definitely not a useful photom file without the phot_table, so we might as well check for it while we're validating.

[melanieclarke]

See 1ab79ec

[tapastro]

👍

[melanieclarke]

Thanks for reviewing!

This PR will need to be coordinated with merging spacetelescope/jwst#9736. When that one is approved, I will:

• bypass requirements and merge this PR
• update pyproject.toml in the jwst PR to point to stdatamodels main
• merge the jwst PR