Add deprecation warnings

Author: emolter

src/stdatamodels/jwst/datamodels/tests/test_open.py

@@ -290,3 +290,16 @@ def test_open_kwargs_fits(tmp_path):
     with pytest.raises(ValidationError):
         with datamodels.open(file_path, strict_validation=True) as model:
             model.validate()
+
+
+def test_memmap_deprecation(tmp_path):
+    """
+    Test that the deprecation warning for memmap=True is raised.
+    """
+    path = str(tmp_path / "test.fits")
+    model = ImageModel((10, 10))
+    model.save(path)
+
+    with pytest.warns(DeprecationWarning, match="Memory mapping is no longer supported"):
+        with datamodels.open(path, memmap=True):
+            pass

src/stdatamodels/jwst/datamodels/util.py

@@ -66,6 +66,15 @@ def open(init=None, guess=True, **kwargs):  # noqa: A001
     """
     from . import model_base
 
+    if "memmap" in kwargs:
+        warnings.warn(
+            "Memory mapping is no longer supported; memmap is hard-coded to False "
+            "and the keyword argument no longer has any effect.",
+            DeprecationWarning,
+            stacklevel=2,
+        )
+        kwargs.pop("memmap")
+
     # Initialize variables used to select model class
 
     hdulist = {}

src/stdatamodels/model_base.py

@@ -133,6 +133,15 @@ def __init__(
             Additional keyword arguments passed to lower level functions. These arguments
             are generally file format-specific.
         """
+        if "memmap" in kwargs:
+            warnings.warn(
+                "Memory mapping is no longer supported; memmap is hard-coded to False "
+                "and the keyword argument no longer has any effect.",
+                DeprecationWarning,
+                stacklevel=2,
+            )
+            kwargs.pop("memmap")
+
         # Override value of validation parameters if not explicitly set.
         if pass_invalid_values is None:
             pass_invalid_values = get_envar_as_boolean("PASS_INVALID_VALUES", False)

tests/test_models.py

@@ -403,3 +403,8 @@ def test_from_fits_deprecation():
 def test_from_asdf_deprecation():
     with pytest.warns(DeprecationWarning, match="from_asdf is deprecated"):
         DataModel.from_asdf({})
+
+
+def test_memmap_deprecation():
+    with pytest.warns(DeprecationWarning, match="Memory mapping is no longer supported"):
+        DataModel(memmap=True)