rcal-859 Update okify script to use GA directories on artifactory (#1282)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: ddavis-stsci

CHANGES.rst

@@ -9,6 +9,8 @@ Documentation
 general
 -------
 
+- Update okify script to use GA directory structure [#1282]
+
 - pin numpy to <2 [#1275]
 
 - refactor exposure level pipeline to use asn's and ModelContainer [#1271]

romancal/scripts/okify_regtests.py

@@ -26,15 +26,9 @@ def parse_args():
     parser = ArgumentParser(description="Okify regression test results")
     parser.add_argument(
         "build_number",
-        help="Jenkins build number for Roman builds",
+        help="GitHub Actions build number for Roman builds",
         metavar="build-number",
     )
-    parser.add_argument(
-        "--job-name",
-        help="Jenkins job name under [RT] (default: romancal)",
-        default="romancal",
-        metavar="job-name",
-    )
     parser.add_argument(
         "--dry-run", action="store_true", help="pass the --dry-run flag to JFrog CLI"
     )
@@ -52,29 +46,28 @@ def artifactory_copy(specfile, dry_run=False):
     subprocess.run(args, check=True)
 
 
-def artifactory_get_breadcrumbs(build_number, job_name, suffix):
+def artifactory_get_breadcrumbs(build_number, suffix):
     """Download specfiles or other breadcrump from Artifactory associated with
     a build number and return a list of their locations on the local file system
 
     An example search would be:
 
     jfrog rt search roman-pipeline-results/*/*_okify.json --props='build.number=540;build.name=RT :: romancal'
     """  # noqa: E501
-    build_name = f"{job_name}"
 
     # Retreive all the okify specfiles for failed tests.
     args = list(
         ["jfrog", "rt", "dl"]
-        + [f"{ARTIFACTORY_REPO}/*RT-{build_name}-{build_number}*/*{suffix}"]
+        + [f"{ARTIFACTORY_REPO}/*_GITHUB_CI_*-{build_number}/*{suffix}"]
     )
     subprocess.run(args, check=True, capture_output=True)
 
     return sorted(glob(f"**/**/*{suffix}"))
 
 
-def artifactory_get_build_artifacts(build_number, job_name):
-    specfiles = artifactory_get_breadcrumbs(build_number, job_name, SPECFILE_SUFFIX)
-    asdffiles = artifactory_get_breadcrumbs(build_number, job_name, RTDATA_SUFFIX)
+def artifactory_get_build_artifacts(build_number):
+    specfiles = artifactory_get_breadcrumbs(build_number, SPECFILE_SUFFIX)
+    asdffiles = artifactory_get_breadcrumbs(build_number, RTDATA_SUFFIX)
 
     if len(specfiles) != len(asdffiles):
         raise RuntimeError("Different number of _okify.json and _rtdata.asdf files")
@@ -100,14 +93,13 @@ def main():
     args = parse_args()
 
     build = args.build_number
-    name = args.job_name
 
     # Create and chdir to a temporary directory to store specfiles
     with tempfile.TemporaryDirectory() as tmpdir:
         print(f"Downloading test okify artifacts to local directory {tmpdir}")
         with pushd(tmpdir):
             # Retreive all the okify specfiles for failed tests.
-            specfiles, asdffiles = artifactory_get_build_artifacts(build, name)
+            specfiles, asdffiles = artifactory_get_build_artifacts(build)
 
             number_failed_tests = len(specfiles)