-
Notifications
You must be signed in to change notification settings - Fork 26
Populate the meta.file_date value with current time when saving. #539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Populate the meta.file_date value with current time when saving. #539
Conversation
|
Note that this includes tiny fixes I noticed in the datamodels subpackage. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #539 +/- ##
==========================================
- Coverage 97.56% 97.54% -0.02%
==========================================
Files 30 40 +10
Lines 2788 4359 +1571
==========================================
+ Hits 2720 4252 +1532
- Misses 68 107 +39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
That looks good. We'll need the romancal PR so that this can pass regtests, but I see that one as well. The regression tests are currently down to the grism / prism issue, which will require a new regtest generation, though the code for generating those is also having issues due to a github runner issue---when it rains, it pours. Happy to merge this one when a regtest run with this and the accompanying romancal PR shows only the expected grism / prism errors. For what it's worth, I'm happy with doing only the meta.file_date part and not the modification time part; I expect the modification times to change again when the files go to the archive and when the files return from the archive and are opened by users, so I don't worry about those bouncing around. |
ecdc9e9 to
19ab0ce
Compare
19ab0ce to
5ec9dd9
Compare
|
@braingram are you happy with these changes? |
|
Regression tests still pass https://github.com/spacetelescope/RegressionTests/actions/runs/16422656955/job/46405106391 |
braingram
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM. Waiting on approval until @PaulHuwe gets the thumbs up from archive folks to restart work on rad/rdm.
b5ef5ea to
f5e5ffa
Compare
f5e5ffa to
c400931
Compare
c400931 to
f219e55
Compare
…te context manager
40fde1c to
98172dd
Compare
Closes #470
This PR updates the
meta.file_dateattribute upon file save to match the current time (and makes sure it matches the time indicated by the filesystem).Tasks
roman_datamodelstests.docs/page.no-changelog-entry-needed.)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types).romancalregression test (https://github.com/spacetelescope/RegressionTests/actions/workflows/romancal.yml) with this branch installed ("git+https://github.com/<fork>/rad@<branch>").News fragment change types:
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change