Skip to content

Conversation

@WilliamJamieson
Copy link
Collaborator

Closes #470

This PR updates the meta.file_date attribute upon file save to match the current time (and makes sure it matches the time indicated by the filesystem).

Tasks

  • Update or add relevant roman_datamodels tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@WilliamJamieson WilliamJamieson requested a review from a team as a code owner July 11, 2025 16:36
@WilliamJamieson
Copy link
Collaborator Author

Note that this includes tiny fixes I noticed in the datamodels subpackage.

@codecov
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

❌ Patch coverage is 96.36364% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.54%. Comparing base (087a60d) to head (98172dd).
⚠️ Report is 209 commits behind head on main.

Files with missing lines Patch % Lines
src/roman_datamodels/datamodels/_utils.py 92.85% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #539      +/-   ##
==========================================
- Coverage   97.56%   97.54%   -0.02%     
==========================================
  Files          30       40      +10     
  Lines        2788     4359    +1571     
==========================================
+ Hits         2720     4252    +1532     
- Misses         68      107      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@schlafly
Copy link
Collaborator

That looks good. We'll need the romancal PR so that this can pass regtests, but I see that one as well. The regression tests are currently down to the grism / prism issue, which will require a new regtest generation, though the code for generating those is also having issues due to a github runner issue---when it rains, it pours.

Happy to merge this one when a regtest run with this and the accompanying romancal PR shows only the expected grism / prism errors. For what it's worth, I'm happy with doing only the meta.file_date part and not the modification time part; I expect the modification times to change again when the files go to the archive and when the files return from the archive and are opened by users, so I don't worry about those bouncing around.

@WilliamJamieson
Copy link
Collaborator Author

@braingram are you happy with these changes?

@WilliamJamieson
Copy link
Collaborator Author

@WilliamJamieson
Copy link
Collaborator Author

Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. Waiting on approval until @PaulHuwe gets the thumbs up from archive folks to restart work on rad/rdm.

@WilliamJamieson WilliamJamieson force-pushed the feature/populate_file_date branch from b5ef5ea to f5e5ffa Compare July 22, 2025 14:43
@WilliamJamieson WilliamJamieson force-pushed the feature/populate_file_date branch from f5e5ffa to c400931 Compare July 28, 2025 14:19
@WilliamJamieson WilliamJamieson force-pushed the feature/populate_file_date branch from c400931 to f219e55 Compare August 4, 2025 14:59
@WilliamJamieson WilliamJamieson force-pushed the feature/populate_file_date branch from 40fde1c to 98172dd Compare August 29, 2025 20:36
@WilliamJamieson WilliamJamieson merged commit 700ebdb into spacetelescope:main Aug 29, 2025
19 of 21 checks passed
@WilliamJamieson WilliamJamieson deleted the feature/populate_file_date branch August 29, 2025 20:48
mairanteodoro pushed a commit to mairanteodoro/roman_datamodels that referenced this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Populate meta.file_date.

3 participants