Skip to content

Conversation

@zacharyburnett
Copy link
Collaborator

analogous to spacetelescope/stdatamodels#583, which is confirmed working

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM this is contained in a pip install of the current commit:

Successfully installed jwst-1.20.0.dev372+gf9c57728c

@zacharyburnett zacharyburnett marked this pull request as ready for review September 11, 2025 17:02
@zacharyburnett zacharyburnett requested a review from a team as a code owner September 11, 2025 17:02
@zacharyburnett zacharyburnett enabled auto-merge (squash) September 11, 2025 17:02
@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.62%. Comparing base (efa4b47) to head (f9c5772).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9823      +/-   ##
==========================================
- Coverage   82.73%   82.62%   -0.11%     
==========================================
  Files         365      366       +1     
  Lines       37324    37529     +205     
==========================================
+ Hits        30881    31010     +129     
- Misses       6443     6519      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zacharyburnett zacharyburnett merged commit 57c558a into spacetelescope:main Sep 11, 2025
26 of 29 checks passed
@zacharyburnett zacharyburnett deleted the config/release-branch-semver branch September 11, 2025 17:12
@pllim
Copy link
Collaborator

pllim commented Sep 11, 2025

Why are we tagging dev tags in release branches?

@zacharyburnett
Copy link
Collaborator Author

Why are we tagging dev tags in release branches?

not on the release branches themselves, but this setting reads the release branches for existing release tags and builds the .dev version off of that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants