Skip to content

Conversation

@emolter
Copy link
Collaborator

@emolter emolter commented Sep 10, 2025

Resolves JP-4112

Closes #9815

This PR fixes a critical bug discovered by ops wherein the NIRCam WFSS Level 3 association rule did not contain the filter name. This bug is causing a program with multiple filters to attempt to gather all exposures into a single spec3 asn and attempt to process them together.

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@emolter emolter changed the title PJ-4112: Add filter to Asn_Lv3WFSSNRC constraints JP-4112: Add filter to Asn_Lv3WFSSNRC constraints Sep 10, 2025
@emolter emolter added this to the Build 12.1 milestone Sep 10, 2025
@emolter
Copy link
Collaborator Author

emolter commented Sep 10, 2025

https://github.com/spacetelescope/RegressionTests/actions/runs/17617769279 regtests started

All the changes are expected: the filter is added back into the product name for NIRCam WFSS, and there are no other changes.

@codecov
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.83%. Comparing base (efa4b47) to head (4eb28f9).
⚠️ Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9816      +/-   ##
==========================================
+ Coverage   82.73%   82.83%   +0.09%     
==========================================
  Files         365      366       +1     
  Lines       37324    37529     +205     
==========================================
+ Hits        30881    31086     +205     
  Misses       6443     6443              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@emolter emolter removed this from the Build 12.1 milestone Sep 10, 2025
@emolter
Copy link
Collaborator Author

emolter commented Sep 10, 2025

Still under discussion whether this will be in 12.1 or a patch release 12.0.2

@melanieclarke melanieclarke added this to the Build 12.0.2 milestone Sep 10, 2025
@melanieclarke
Copy link
Collaborator

I made a Build 12.0.2 milestone and attached it here, for now. We can revise/close that milestone later if it's decided it's not needed.

@emolter emolter marked this pull request as ready for review September 10, 2025 19:45
@emolter emolter requested review from a team as code owners September 10, 2025 19:45
@tapastro tapastro merged commit b04c912 into spacetelescope:main Sep 11, 2025
37 of 38 checks passed
@emolter emolter deleted the JP-4112 branch September 11, 2025 18:27
zacharyburnett pushed a commit to zacharyburnett/jwst that referenced this pull request Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Level 3 NIRCam WFSS product names missing filter

3 participants