-
Notifications
You must be signed in to change notification settings - Fork 180
JP-4112: Add filter to Asn_Lv3WFSSNRC constraints #9816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
https://github.com/spacetelescope/RegressionTests/actions/runs/17617769279 regtests started All the changes are expected: the filter is added back into the product name for NIRCam WFSS, and there are no other changes. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9816 +/- ##
==========================================
+ Coverage 82.73% 82.83% +0.09%
==========================================
Files 365 366 +1
Lines 37324 37529 +205
==========================================
+ Hits 30881 31086 +205
Misses 6443 6443 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Still under discussion whether this will be in 12.1 or a patch release 12.0.2 |
|
I made a Build 12.0.2 milestone and attached it here, for now. We can revise/close that milestone later if it's decided it's not needed. |
Co-authored-by: Tyler Pauly <[email protected]>
Resolves JP-4112
Closes #9815
This PR fixes a critical bug discovered by ops wherein the NIRCam WFSS Level 3 association rule did not contain the filter name. This bug is causing a program with multiple filters to attempt to gather all exposures into a single spec3 asn and attempt to process them together.
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)docs/pageokify_regteststo update the truth files