JP-3888: Turn on bright_use_group1 in firstframe; flag any affected pixels

[melanieclarke]

Resolves JP-3888

Turn on bright_use_group1 by default for the firstframe step. Also, flag any affected pixels in the pixeldq image with the FLUX_ESTIMATED flag.

Tasks

• If you have a specific reviewer in mind, tag them.
• add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
• Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
  • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • start a regression test and include a link to the running job (click here for instructions)
    • Do truth files need to be updated ("okified")?
      • after the reviewer has approved these changes, run okify_regtests to update the truth files
• if a JIRA ticket exists, make sure it is resolved properly

[melanieclarke]

Regression tests:
https://github.com/spacetelescope/RegressionTests/actions/runs/17560084922

Diffs in the MIRI image and MIRI dark pipeline are because bright_use_group1 is now True by default and there are a handful of pixels that are affected by the change.

I looked into why there are many more diffs in the pixeldq than in the groupdq for the MIRI image diffs. It looks like in nearly all cases, the DO_NOT_USE bit was already set for pixels affected by the bright_use_group1 parameter, for other reasons. For this test exposure, there are 174 pixels now marked FLUX_ESTIMATED, but only 9 of them were not already DO_NOT_USE in the pixeldq image.

Since this is an informational flag, I think it's still probably useful to apply the flag to all pixels that qualify, regardless of whether or not they'll eventually be used, but let me know if anyone thinks differently.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.41%. Comparing base (94c0254) to head (2593cc7).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9807      +/-   ##
==========================================
+ Coverage   83.38%   83.41%   +0.03%     
==========================================
  Files         366      366              
  Lines       37770    37786      +16     
==========================================
+ Hits        31493    31520      +27     
+ Misses       6277     6266      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jemorrison]

This look fine. I have no suggestions.

[melanieclarke]

Updated regtests for okifying:
https://github.com/spacetelescope/RegressionTests/actions/runs/17776255262

[tapastro]

Looks good!