Skip to content

Conversation

@braingram
Copy link
Collaborator

@braingram braingram commented Sep 5, 2025

opencv is not used directly in jwst.

The jump step does use opencv but only via stcal (which has opencv as a dependency).

This PR removes opencv as a direct dependency to jwst.

Regtests: https://github.com/spacetelescope/RegressionTests/actions/runs/17494168542
all pass and show opencv installed "via stcal":
https://github.com/spacetelescope/RegressionTests/actions/runs/17494168542/job/49690870643#step:17:80

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.57%. Comparing base (53e8b83) to head (b77c94d).
⚠️ Report is 208 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9803   +/-   ##
=======================================
  Coverage   82.57%   82.57%           
=======================================
  Files         366      366           
  Lines       37295    37295           
=======================================
  Hits        30796    30796           
  Misses       6499     6499           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@braingram braingram marked this pull request as ready for review September 5, 2025 15:36
@braingram braingram requested a review from a team as a code owner September 5, 2025 15:36
@braingram braingram changed the title drop opencv dependency drop opencv direct dependency Sep 5, 2025
@pllim pllim requested a review from melanieclarke September 5, 2025 17:05
@melanieclarke melanieclarke added this to the Build 12.1 milestone Sep 5, 2025
@melanieclarke melanieclarke merged commit d9b854e into spacetelescope:main Sep 5, 2025
28 checks passed
@braingram braingram deleted the no_opencv branch September 5, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants