-
Notifications
You must be signed in to change notification settings - Fork 180
Fix conftest import #9715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix conftest import #9715
Conversation
|
Regtests shouldn't be needed, but running them anyway just in case: All passing. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9715 +/- ##
=======================================
Coverage 82.11% 82.11%
=======================================
Files 367 368 +1
Lines 37482 37484 +2
=======================================
+ Hits 30778 30780 +2
Misses 6704 6704 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pllim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general, just some minor comments. Thanks!
I wonder if we should add __all__ to test helper modules...
Probably. I'll add it. |
pllim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
emolter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Melanie, looks great overall. I had a question about some docstring changes
4401d94 to
6d2acac
Compare
Closes #9714
Reorganize test data to avoid importing directly from conftest files.
The biggest change here is to the extract_1d conftest file. Currently, only a couple of the fixtures there have been converted to functions to allow them to be reused elsewhere. Since many of them are useful synthetic structures for testing a wide variety of spectral modes, I went ahead and converted almost all the fixtures to functions and moved their implementation to the helpers module. I left a few as fixture-only input data, for tests specific to extract_1d utilities. They could be moved to the helpers later, if they turn out to be useful elsewhere.
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)docs/pageokify_regteststo update the truth files