-
Notifications
You must be signed in to change notification settings - Fork 180
Clean up help message style and contents #9686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up help message style and contents #9686
Conversation
|
Regtests: All passing. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9686 +/- ##
==========================================
+ Coverage 81.26% 81.28% +0.01%
==========================================
Files 368 368
Lines 37499 37501 +2
==========================================
+ Hits 30475 30484 +9
+ Misses 7024 7017 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3beafe4 to
e0d142b
Compare
|
I like the concept, but at a glance, I am not sure if all the new text will be formatted properly. We should go to the rendered doc for this PR and make sure the formatting is actually correct. |
pllim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW LGTM thanks!
9926b33 to
79dd804
Compare
79dd804 to
0a6e722
Compare
|
@tapastro - this PR is also ready for review |
tapastro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from a help message perspective, but it seems a shame to remove some of the expanded explanations for step paramters. Would it be worth preserving them in a dedicated long-form comment after the spec definition, or do you not think they add enough value?
I checked before I removed them -- they're all captured in the arguments documentation for the step in RTD. I don't think we need them in both places. |
Closes #9676
Class docstrings for Step and Pipeline classes get used as the summary in the command-line help message (e.g.
strun flat_field -h).Clean up, remove, or relocate step and pipeline docstrings that don't format well with
-h.Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)docs/pageokify_regteststo update the truth files