Skip to content

Conversation

@melanieclarke
Copy link
Collaborator

@melanieclarke melanieclarke commented Jul 16, 2025

Resolves JP-4060

Catch an edge case where a NIRSpec imaging WCS is assigned, but a spectroscopic bounding box is attempted.

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@melanieclarke melanieclarke added this to the 12.0.1 milestone Jul 16, 2025
@melanieclarke
Copy link
Collaborator Author

melanieclarke commented Jul 16, 2025

@melanieclarke melanieclarke modified the milestones: 12.0.1, Build 12.1 Jul 16, 2025
@codecov
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (8409d2b) to head (7620488).
⚠️ Report is 362 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff           @@
##            main   #9659    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files        367     367            
  Lines      37332   37186   -146     
======================================
+ Misses     37332   37186   -146     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@melanieclarke melanieclarke marked this pull request as ready for review July 17, 2025 11:45
@melanieclarke melanieclarke requested review from a team as code owners July 17, 2025 11:45
@melanieclarke melanieclarke requested a review from tapastro July 17, 2025 12:04
@tapastro tapastro merged commit 6e40d91 into spacetelescope:main Jul 17, 2025
28 checks passed
@zacharyburnett
Copy link
Collaborator

@meeseeksdev backport to release/1.19.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants