-
Notifications
You must be signed in to change notification settings - Fork 180
Update pre-commit hooks #9623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pre-commit hooks #9623
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #9623 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 367 367
Lines 37365 37313 -52
=====================================
+ Misses 37365 37313 -52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
emolter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me overall. It's a bit unfortunate that none of the lines that were touched have unit test coverage... it would be good to run regression tests just to be sure.
With regards to the pre-commit bot, it does sound good but TBH I'm probably the wrong person to ask
We have the bot on |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Those look like the result of a crds update? |
|
RT passed. |
b5ef5ca to
5b332f6
Compare
melanieclarke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
I'll leave the bot conversation for later, if someone wants to pursue it (@tapastro @zacharyburnett ?)
|
Follow-up issue for bot at #9645 |
I noticed that several of the pre-commit hook versions were extremely out of date this PR updates them and fixes all the issues those updates uncovered.
I suggest that JWST use the
pre-commit.cibot like romancal does. It provides the style checks like the current workflow provides. In addition it provides in PR fixing tools and automatic updates to the pre-commit.ci config. If we don't want to go that root, something like https://github.com/marketplace/actions/pre-commit-autoupdate should be used.Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)docs/pageokify_regteststo update the truth files