Skip to content

Conversation

@WilliamJamieson
Copy link
Collaborator

@WilliamJamieson WilliamJamieson commented Jul 9, 2025

I noticed that several of the pre-commit hook versions were extremely out of date this PR updates them and fixes all the issues those updates uncovered.

I suggest that JWST use the pre-commit.ci bot like romancal does. It provides the style checks like the current workflow provides. In addition it provides in PR fixing tools and automatic updates to the pre-commit.ci config. If we don't want to go that root, something like https://github.com/marketplace/actions/pre-commit-autoupdate should be used.

Tasks

@WilliamJamieson WilliamJamieson requested review from a team as code owners July 9, 2025 20:28
@pllim pllim requested a review from emolter July 9, 2025 20:31
@codecov
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

❌ Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (d875f84) to head (a1763ec).
⚠️ Report is 391 commits behind head on main.

Files with missing lines Patch % Lines
jwst/scripts/stfitsdiff.py 0.00% 6 Missing ⚠️
jwst/scripts/collect_pipeline_cfgs.py 0.00% 3 Missing ⚠️
jwst/scripts/schemadoc.py 0.00% 3 Missing ⚠️
jwst/scripts/world_coords.py 0.00% 2 Missing ⚠️
jwst/associations/lib/constraint.py 0.00% 1 Missing ⚠️
jwst/associations/mkpool.py 0.00% 1 Missing ⚠️
jwst/lib/set_telescope_pointing.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #9623   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files        367     367           
  Lines      37365   37313   -52     
=====================================
+ Misses     37365   37313   -52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@emolter emolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me overall. It's a bit unfortunate that none of the lines that were touched have unit test coverage... it would be good to run regression tests just to be sure.

With regards to the pre-commit bot, it does sound good but TBH I'm probably the wrong person to ask

@pllim
Copy link
Collaborator

pllim commented Jul 9, 2025

pre-commit bot

We have the bot on astropy and seems to work fine. Can get annoying if upstream keeps changing but also depends on your setup (opt-in vs opt-out). I think we should try it here.

@pllim

This comment was marked as resolved.

@pllim

This comment was marked as resolved.

@github-actions github-actions bot added the FGS label Jul 10, 2025
@WilliamJamieson
Copy link
Collaborator Author

RT failed but I don't see how it is related? spacetelescope/RegressionTests/actions/runs/16180831251/job/45676952501

Those look like the result of a crds update?

@pllim
Copy link
Collaborator

pllim commented Jul 10, 2025

@pllim
Copy link
Collaborator

pllim commented Jul 10, 2025

RT passed.

Copy link
Collaborator

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

I'll leave the bot conversation for later, if someone wants to pursue it (@tapastro @zacharyburnett ?)

@melanieclarke melanieclarke enabled auto-merge July 15, 2025 14:06
@melanieclarke melanieclarke merged commit c0a80fa into spacetelescope:main Jul 15, 2025
24 checks passed
@pllim
Copy link
Collaborator

pllim commented Jul 15, 2025

Follow-up issue for bot at #9645

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants