-
Notifications
You must be signed in to change notification settings - Fork 180
JP-4047: Update regtests for niriss and nircam wfss #9602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9602 +/- ##
==========================================
- Coverage 80.66% 79.47% -1.20%
==========================================
Files 368 368
Lines 37294 37224 -70
==========================================
- Hits 30085 29585 -500
- Misses 7209 7639 +430 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
https://github.com/spacetelescope/RegressionTests/actions/runs/15887901780
Regression test differences were due to Mac vs Linux, but as @tapastro spotted, they were hiding a bug in casting between data types. This should be fixed in 74e3e05 |
|
I found a simpler and more robust fix that takes the defaults from the schema defaults, e.g. here. This way of doing it makes it so no special handling of different column datatypes is needed, and no hard-coding of default values has to be done for those dtypes. Regression tests restarted here: There's a good chance this may also affect the TSO multispec products, since the fix was applied to a shared utility. The new behavior should be appropriate for those products too, but with a caveat: the default DQ column for TSO multispec data was set to 0 instead of 1. It makes more sense for the default to be 1, i.e. Obviously we should be careful evaluating the differences with TSO products, and I'll take a look at them locally, but in principle they can be ok-ified. Suggested workflow would be to merge the stdatamodels change first, as I don't expect any regtest failures from that one, and then to re-run the jwst regtests to get a cleanly okify-able run (although those failures should be the same as from the run above). |
|
This did NOT affect the TSO regtests. The WFSS spec2 x1d regtest failures from https://github.com/spacetelescope/RegressionTests/actions/runs/16056215256 look as expected. That regtest was pinned to spacetelescope/stdatamodels#522 branch, but the change therein should not have made any difference. Nevertheless, starting a (hopefully final) regtest, this one from stdatamodels main https://github.com/spacetelescope/RegressionTests/actions/runs/16057873804 |
This is expected for TSO data - all integrations in an extension have the same wavelength solution. We currently keep spectra from different detectors, which would have different spectral lengths, in separate extensions. I think the spectral padding for TSO data should still be available as a fallback, in case this convention changes in the future, but it should never be used under current assumptions. |
tapastro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests look good, RTs show expected difference from update to default DQ handling.
|
@meeseeksdev backport to release/1.19.x |
…and nircam wfss
…for niriss and nircam wfss) (#9634) Co-authored-by: Ned Molter <[email protected]>
Resolves JP-4047
Closes #9596
This PR:
Once merged, the following files should be removed from Artifactory:
truth/test_niriss_wfss/*gr150c-gr150r*niriss/wfss/jw01324-o001_20220629t171902_spec3_003_asn.jsonniriss/wfss/jw01324-o001_20220629t171902_spec2_002_asn.jsonjw01324001001_03101_00002_nis_rate.fitsTasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)docs/pageokify_regteststo update the truth files