Remove attempted handling of memmap in container #9593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9593 +/- ##
==========================================
+ Coverage 0.00% 79.48% +79.48%
==========================================
Files 368 368
Lines 37228 37228
==========================================
+ Hits 0 29589 +29589
+ Misses 37228 7639 -29589 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5 tasks
Collaborator
Author
emolter
commented
Jun 26, 2025
| """ | ||
|
|
||
| def __init__(self, init=None, asn_exptypes=None, asn_n_members=None, **kwargs): | ||
| def __init__(self, init=None, asn_exptypes=None, asn_n_members=None, **kwargs): # noqa: ARG002 |
Collaborator
Author
There was a problem hiding this comment.
this is needed to allow keywords to be passed in but ignored, which is the current behavior. see #9590 where this will be fixed
Contributor
|
@meeseeksdev backport to release/1.19.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jwst
that referenced
this pull request
Jul 11, 2025
tapastro
pushed a commit
that referenced
this pull request
Jul 11, 2025
… of memmap in container) (#9633) Co-authored-by: Ned Molter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
memmapoption fromModelContainer. No changelog is needed becausememmapwas not documented as an available parameter anywhere, including in theModelContainerdocstring.See also #9590 which will allow
ModelContainerto pass keyword arguments through todatamodels.open()on individual models, which is related but either PR could go in first (rebasing the second one).This PR must be merged before it is safe to merge spacetelescope/stdatamodels#507
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)docs/pageokify_regteststo update the truth files