Skip to content

Conversation

@zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Jun 9, 2025

@zacharyburnett zacharyburnett self-assigned this Jun 9, 2025
@zacharyburnett zacharyburnett requested review from a team as code owners June 9, 2025 17:03
@zacharyburnett zacharyburnett changed the title Backport PR #9501 on branch release/1.18.x (JP-3116: Use duplication checking to prevent undesirable associations in DMS operations) Backport PR #9507 on branch release/1.18.x (JP-3116: Use duplication checking to prevent undesirable associations in DMS operations) Jun 9, 2025
@zacharyburnett zacharyburnett changed the title Backport PR #9507 on branch release/1.18.x (JP-3116: Use duplication checking to prevent undesirable associations in DMS operations) Backport PR #9507: JP-4021: Fix a bug where insufficient valid background pixels case was not caught for WFSS background step Jun 9, 2025
@codecov
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release/1.18.x@699bda8). Learn more about missing BASE report.

Files with missing lines Patch % Lines
jwst/background/background_sub_wfss.py 66.66% 4 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             release/1.18.x    #9528   +/-   ##
=================================================
  Coverage                  ?   74.60%           
=================================================
  Files                     ?      369           
  Lines                     ?    37163           
  Branches                  ?        0           
=================================================
  Hits                      ?    27727           
  Misses                    ?     9436           
  Partials                  ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zacharyburnett
Copy link
Collaborator Author

@zacharyburnett
Copy link
Collaborator Author

the only test NEWLY failing (not also failing on main) is jwst.regtest.test_niriss_wfss::test_nis_wfss_spec2[extract_2d]:
https://github.com/spacetelescope/RegressionTests/actions/runs/15542519446/attempts/1#summary-43756624199

…t valid background pixels case was not caught for WFSS background step
@zacharyburnett zacharyburnett force-pushed the auto-backport-of-pr-9507-on-release/1.18.x branch from 1d7bf37 to b0991a8 Compare June 10, 2025 14:34
@zacharyburnett zacharyburnett merged commit b92e536 into spacetelescope:release/1.18.x Jun 10, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants