Skip to content

Conversation

@melanieclarke
Copy link
Collaborator

@melanieclarke melanieclarke commented May 20, 2025

Fix a small bug stemming from code style fixes. There were a couple malformed log messages in off-nominal refpix use cases.

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@melanieclarke melanieclarke added this to the Build 12.0 milestone May 20, 2025
@melanieclarke
Copy link
Collaborator Author

melanieclarke commented May 20, 2025

@codecov
Copy link

codecov bot commented May 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.90%. Comparing base (8478131) to head (3de2d04).
⚠️ Report is 667 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9478   +/-   ##
=======================================
  Coverage   77.90%   77.90%           
=======================================
  Files         362      362           
  Lines       36341    36334    -7     
=======================================
- Hits        28310    28307    -3     
+ Misses       8031     8027    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@melanieclarke melanieclarke marked this pull request as ready for review May 20, 2025 18:46
@melanieclarke melanieclarke requested review from a team as code owners May 20, 2025 18:46
@melanieclarke melanieclarke merged commit c6a5c1d into spacetelescope:main May 20, 2025
23 checks passed
@melanieclarke melanieclarke deleted the fix_log_messages branch May 20, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants