-
Notifications
You must be signed in to change notification settings - Fork 180
JP-3988: Enhance the table reports for STFITSDiff #9413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3988: Enhance the table reports for STFITSDiff #9413
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9413 +/- ##
==========================================
+ Coverage 76.58% 77.27% +0.68%
==========================================
Files 364 362 -2
Lines 36595 36279 -316
==========================================
+ Hits 28028 28035 +7
+ Misses 8567 8244 -323 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ers from command line
melanieclarke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the new reports!
There are a couple little weird things to track down in the new table reports and HDU ignoring - I'll keep working with you offline on those.
In the meantime, a couple other small suggestions below, and also:
I can't add a comment in the right place, but for some data I get an annoying RuntimeWarning ("invalid value encountered in subtract") in the diff_total calculation in 982. Can you please filter it out?
melanieclarke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All my comments are addressed and local tests look good. No need for regtests, since this code is as-yet unused.
Resolves JP-3988
This PR addresses enhancing the reports for table differences and enables providing strings and integers to the list of HDUs to ignore. The name of this option is ignore_hdus and it lives in the fitsdiff_default_kwargs dictionary set up in the specific test(s).
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)docs/pageokify_regteststo update the truth files