Skip to content

Conversation

@pllim
Copy link
Collaborator

@pllim pllim commented Apr 7, 2025

This PR reverts adding G004 into the checks. It was added in #9276 . Addressing formatting of logger string is now on hold.

No need for regression tests.

Alternative to #9292

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@pllim pllim added this to the Build 12.0 milestone Apr 7, 2025
@pllim pllim requested a review from melanieclarke April 7, 2025 17:12
@pllim pllim requested a review from a team as a code owner April 7, 2025 17:12
@codecov
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.18%. Comparing base (4a08d6c) to head (c50dd2f).
Report is 685 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9367   +/-   ##
=======================================
  Coverage   75.18%   75.18%           
=======================================
  Files         368      368           
  Lines       36837    36837           
=======================================
  Hits        27696    27696           
  Misses       9141     9141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Thanks!

@melanieclarke melanieclarke merged commit f8e2bfe into spacetelescope:main Apr 7, 2025
30 of 31 checks passed
@pllim pllim deleted the revert-g004-engdblog branch April 7, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants