Skip to content

Conversation

@melanieclarke
Copy link
Collaborator

@melanieclarke melanieclarke commented Mar 26, 2025

Resolves JP-3953

Fix an unintended regression introduced by #9085. The current barshadow reference files do not cover all valid wavelengths for all gratings, so the interpolation for the correction needs to extrapolate to cover the gaps.

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@melanieclarke melanieclarke added this to the Build 11.3 milestone Mar 26, 2025
@melanieclarke
Copy link
Collaborator Author

melanieclarke commented Mar 26, 2025

Regression tests running here:
https://github.com/spacetelescope/RegressionTests/actions/runs/14084928772

The MOS spec2 test runs on G235M data, which is one of the affected gratings. Running locally, it looks like one of the 6 extracted slits is impacted by the wavelength gap, so I expect to see change in EXTVER 6 for the output products.

Edit:
Regression tests show expected diffs in the MOS spec2 test, similar diffs in the MOS FS spec2 test (using G395M), and additionally some changes in BARSHADOW extension only, for the MOS moving target test and the MOS master background test.

For these last two, the grating is PRISM, so no wavelength gaps are expected. There are now some extrapolated barshadow values at the edges of the arrays, where valid wavelengths are defined, but there is no reference data -- this has no impact on the science data, which is NaN in those regions.

@codecov
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.69%. Comparing base (86af1f2) to head (2af0321).
Report is 741 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9326   +/-   ##
=======================================
  Coverage   74.69%   74.69%           
=======================================
  Files         369      368    -1     
  Lines       37117    37106   -11     
=======================================
- Hits        27723    27717    -6     
+ Misses       9394     9389    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@melanieclarke melanieclarke marked this pull request as ready for review March 27, 2025 13:36
@melanieclarke melanieclarke requested review from a team as code owners March 27, 2025 13:36
@melanieclarke melanieclarke requested a review from tapastro March 27, 2025 13:37
@melanieclarke
Copy link
Collaborator Author

@tapastro - this will need to go into an rc2 for 1.18.0. I have marked it for Build 11.3.

Copy link
Contributor

@tapastro tapastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tapastro tapastro merged commit 55e6a81 into spacetelescope:main Mar 27, 2025
29 checks passed
@tapastro
Copy link
Contributor

@meeseeksdev backport to release/1.18.x

@pllim
Copy link
Collaborator

pllim commented Mar 27, 2025

Tada: #9335

@melanieclarke melanieclarke deleted the jp-3953 branch March 27, 2025 20:42
tapastro pushed a commit that referenced this pull request Mar 28, 2025
…hadow correction to cover wavelength gaps) (#9335)

Co-authored-by: Melanie Clarke <[email protected]>
Co-authored-by: P. L. Lim <[email protected]>
taylorbell57 pushed a commit to taylorbell57/jwst that referenced this pull request Apr 30, 2025
taylorbell57 pushed a commit to taylorbell57/jwst that referenced this pull request Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants