-
Notifications
You must be signed in to change notification settings - Fork 180
JP-3953: Extrapolate barshadow correction to cover wavelength gaps #9326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Regression tests running here: The MOS spec2 test runs on G235M data, which is one of the affected gratings. Running locally, it looks like one of the 6 extracted slits is impacted by the wavelength gap, so I expect to see change in EXTVER 6 for the output products. Edit: For these last two, the grating is PRISM, so no wavelength gaps are expected. There are now some extrapolated barshadow values at the edges of the arrays, where valid wavelengths are defined, but there is no reference data -- this has no impact on the science data, which is NaN in those regions. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9326 +/- ##
=======================================
Coverage 74.69% 74.69%
=======================================
Files 369 368 -1
Lines 37117 37106 -11
=======================================
- Hits 27723 27717 -6
+ Misses 9394 9389 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@tapastro - this will need to go into an rc2 for 1.18.0. I have marked it for Build 11.3. |
tapastro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@meeseeksdev backport to release/1.18.x |
…ction to cover wavelength gaps
|
Tada: #9335 |
…hadow correction to cover wavelength gaps) (#9335) Co-authored-by: Melanie Clarke <[email protected]> Co-authored-by: P. L. Lim <[email protected]>
…pacetelescope#9326) Co-authored-by: Tyler Pauly <[email protected]>
…pacetelescope#9326) Co-authored-by: Tyler Pauly <[email protected]>
Resolves JP-3953
Fix an unintended regression introduced by #9085. The current barshadow reference files do not cover all valid wavelengths for all gratings, so the interpolation for the correction needs to extrapolate to cover the gaps.
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)docs/pageokify_regteststo update the truth files