remove schema_editor #8909
Merged
remove schema_editor #8909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braingram
force-pushed
the
remove_schema_editor
branch
from
315fab2 to
b41b2d4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8909 +/- ##
==========================================
- Coverage 64.51% 63.68% -0.84%
==========================================
Files 376 375 -1
Lines 38733 38689 -44
==========================================
- Hits 24990 24638 -352
- Misses 13743 14051 +308 ☔ View full report in Codecov by Sentry. |
braingram
force-pushed
the
remove_schema_editor
branch
from
b41b2d4 to
bfb5689
Compare
braingram
commented
Oct 30, 2024
Comment on lines
-20
to
-22
| KEYWORD_DB = 'datamodels/keyword_db' | ||
| FIXED_SCHEMA = 'fixed' | ||
| SCHEMA_TRUTH = 'truth/test_schema_editor' |
Collaborator
Author
There was a problem hiding this comment.
Once merged these artifactory directories could be removed. The copy of the keyword dictionary looks to be from 2020.
5 tasks
braingram
force-pushed
the
remove_schema_editor
branch
from
bfb5689 to
1f87cb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes schema_editor including:
schema_editorinstalled scriptschema_editorsubmodule viajwst.datamodelsschema_editorregression testsThis script was used for comparing keyword dictionary and datamodel schema fits keyword definitions. It will be replaced by the private
kwtoolin stdatamodels: spacetelescope/stdatamodels#337Once merged
https://innerspace.stsci.edu/pages/viewpage.action?spaceKey=SCSB&title=Keyword+Dictionary+JSON+vs.+YAML+Comparison+Process
can be updated to reflect the new process.
A follow-up PR will remove
schema_editorfrom stdatamodels: spacetelescope/stdatamodels#352Regression tests: https://github.com/spacetelescope/RegressionTests/actions/runs/11618412360
show 1 unrelated failure (same as main) and 1 due to an artifactory hiccup which resulted in the failure to download a file (likely due to the network issues today)
I'd say this removes schema_editor so this PR
Closes https://jira.stsci.edu/browse/JP-2131
Closes https://jira.stsci.edu/browse/JP-3783
Closes https://jira.stsci.edu/browse/AL-798
Closes https://jira.stsci.edu/browse/JP-2383
Tasks
Build 11.3(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)docs/pageokify_regteststo update the truth filesnews fragment change types...
changes/<PR#>.general.rst: infrastructure or miscellaneous changechanges/<PR#>.docs.rstchanges/<PR#>.stpipe.rstchanges/<PR#>.datamodels.rstchanges/<PR#>.scripts.rstchanges/<PR#>.fits_generator.rstchanges/<PR#>.set_telescope_pointing.rstchanges/<PR#>.pipeline.rststage 1
changes/<PR#>.group_scale.rstchanges/<PR#>.dq_init.rstchanges/<PR#>.emicorr.rstchanges/<PR#>.saturation.rstchanges/<PR#>.ipc.rstchanges/<PR#>.firstframe.rstchanges/<PR#>.lastframe.rstchanges/<PR#>.reset.rstchanges/<PR#>.superbias.rstchanges/<PR#>.refpix.rstchanges/<PR#>.linearity.rstchanges/<PR#>.rscd.rstchanges/<PR#>.persistence.rstchanges/<PR#>.dark_current.rstchanges/<PR#>.charge_migration.rstchanges/<PR#>.jump.rstchanges/<PR#>.clean_flicker_noise.rstchanges/<PR#>.ramp_fitting.rstchanges/<PR#>.gain_scale.rststage 2
changes/<PR#>.assign_wcs.rstchanges/<PR#>.badpix_selfcal.rstchanges/<PR#>.msaflagopen.rstchanges/<PR#>.nsclean.rstchanges/<PR#>.imprint.rstchanges/<PR#>.background.rstchanges/<PR#>.extract_2d.rstchanges/<PR#>.master_background.rstchanges/<PR#>.wavecorr.rstchanges/<PR#>.srctype.rstchanges/<PR#>.straylight.rstchanges/<PR#>.wfss_contam.rstchanges/<PR#>.flatfield.rstchanges/<PR#>.fringe.rstchanges/<PR#>.pathloss.rstchanges/<PR#>.barshadow.rstchanges/<PR#>.photom.rstchanges/<PR#>.pixel_replace.rstchanges/<PR#>.resample_spec.rstchanges/<PR#>.residual_fringe.rstchanges/<PR#>.cube_build.rstchanges/<PR#>.extract_1d.rstchanges/<PR#>.resample.rststage 3
changes/<PR#>.assign_mtwcs.rstchanges/<PR#>.mrs_imatch.rstchanges/<PR#>.tweakreg.rstchanges/<PR#>.skymatch.rstchanges/<PR#>.exp_to_source.rstchanges/<PR#>.outlier_detection.rstchanges/<PR#>.tso_photometry.rstchanges/<PR#>.stack_refs.rstchanges/<PR#>.align_refs.rstchanges/<PR#>.klip.rstchanges/<PR#>.spectral_leak.rstchanges/<PR#>.source_catalog.rstchanges/<PR#>.combine_1d.rstchanges/<PR#>.ami.rstother
changes/<PR#>.wfs_combine.rstchanges/<PR#>.white_light.rstchanges/<PR#>.cube_skymatch.rstchanges/<PR#>.engdb_tools.rstchanges/<PR#>.guider_cds.rst