Skip to content

Conversation

@hbushouse
Copy link
Collaborator

@hbushouse hbushouse commented Aug 17, 2023

This PR removes the XFAIL setting in the asn regtests for the program jw00016 pool, now that JP-3230 and JP-3232 have been completed. The first regtest run will result in differences, which can then be okified.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@hbushouse
Copy link
Collaborator Author

Limited regtest run for asn tests only started at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/869

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (589917d) 76.52% compared to head (dec86c0) 76.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7830   +/-   ##
=======================================
  Coverage   76.52%   76.52%           
=======================================
  Files         456      456           
  Lines       36964    36964           
=======================================
  Hits        28285    28285           
  Misses       8679     8679           
Flag Coverage Δ *Carryforward flag
nightly 77.39% <ø> (ø) Carriedforward from 3790db0

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hbushouse
Copy link
Collaborator Author

Hmmm, regtest doesn't seem to be working right. Probably entered the pytest arguments wrong, in my attempt to limit to only asn tests. Worked from the command line!

@tapastro
Copy link
Contributor

@hbushouse
Copy link
Collaborator Author

Regtest: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/870/testReport/

Cool. thanks! Yeah, those are all the changes we'd expect, in terms of differences between rate/rateints and cal/calints files.

@hbushouse hbushouse merged commit 6a62c0d into spacetelescope:master Aug 17, 2023
@hbushouse hbushouse deleted the asn_regtest_fix branch August 17, 2023 18:44
mairanteodoro pushed a commit to mairanteodoro/jwst that referenced this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants