-
Notifications
You must be signed in to change notification settings - Fork 180
Remove regtest XFAIL for fixed ASN rule #7830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Limited regtest run for asn tests only started at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/869 |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #7830 +/- ##
=======================================
Coverage 76.52% 76.52%
=======================================
Files 456 456
Lines 36964 36964
=======================================
Hits 28285 28285
Misses 8679 8679
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Hmmm, regtest doesn't seem to be working right. Probably entered the pytest arguments wrong, in my attempt to limit to only asn tests. Worked from the command line! |
Cool. thanks! Yeah, those are all the changes we'd expect, in terms of differences between rate/rateints and cal/calints files. |
This PR removes the XFAIL setting in the asn regtests for the program jw00016 pool, now that JP-3230 and JP-3232 have been completed. The first regtest run will result in differences, which can then be okified.
Checklist for maintainers
CHANGES.rstwithin the relevant release sectionHow to run regression tests on a PR