-
Notifications
You must be signed in to change notification settings - Fork 180
Modify test_flatfield_step_interface step to not interfere with other tests
#7752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Regression tests running: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/802/ |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #7752 +/- ##
=======================================
Coverage 76.60% 76.60%
=======================================
Files 456 456
Lines 36950 36950
=======================================
+ Hits 28304 28305 +1
+ Misses 8646 8645 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
test_flatfield_step_interface step to not interfere with other tests
cb90b52 to
c021c8e
Compare
nden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😱
Good catch!
|
Thanks for the review! It looks like I'm not authorized to merge this. The regression tests are almost done (stuck on the last 98%) but should finish in about 30 minutes (and so far no errors have been hit). I did run these tests with |
hbushouse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works! YAY!!!
The
test_flatfield_step_interfacewas unskipped in #7615 right before the frequent but unpredictable failures for FlatField.This test modifies
FlatFieldStep.reference_file_types(and does not undo the modification). Subsequent tests (in the same process) that useFlatFieldmay fail (and not consider f/s/dflats) which would explain the errors seen in regression tests following the merge of the above changes.This minimal regression test run (2 tests in one process) will hopefully help to explain the error:
https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FJWST-Developers-Pull-Requests/detail/JWST-Developers-Pull-Requests/799/tests
The order of tests was controlled so that
test_flatfield_step_interfacewas called prior totest_nis_wfss_spec2(which fails with the expected error).This PR modifies the test to save, modify then restore
FlatFieldStep.reference_file_typesso that it doesn't interfere with other tests.Checklist for maintainers
CHANGES.rstwithin the relevant release sectionHow to run regression tests on a PR