JP-3285: Allow negative angles in engineering format. Add support for angle units #7683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcara
force-pushed
the
improve-adjust-wcs
branch
2 times, most recently
from
88782a9 to
67de12a
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #7683 +/- ##
==========================================
- Coverage 76.62% 76.56% -0.07%
==========================================
Files 456 456
Lines 36833 36877 +44
==========================================
+ Hits 28223 28234 +11
- Misses 8610 8643 +33
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
hbushouse
approved these changes
Jul 1, 2023
| group, the timing for these ramps is not group time. These adjusted times | ||
| are now used. [#7612, spacetelescope/stcal#173] | ||
|
|
||
| tweakreg |
Collaborator
There was a problem hiding this comment.
These entries need to be moved to the top of the log, in the unreleased section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JP-3285
This PR fixes a bug in the
adjust_wcsscript that would prevent setting angles to negative numbers in the engineering format (a limitation ofargparse). This PR also adds support for units for angles. For example, now the scrpt can be invoked like this:When angle units are not provided (as for the DEC angle correction above), the angles are still assumed to be in degrees.
Finally, this PR adds functions from the
tweakreg.utilsmodule to the__all__variable thus publishing the docstrings of these functions in thejwstdocumentation.Checklist for maintainers
CHANGES.rstwithin the relevant release sectionHow to run regression tests on a PR