thread: refine the joinable implementation

skypjack · skypjack · commit a5870f3595eb · 2025-11-28T08:57:49.000+01:00
diff --git a/src/uvw/thread.ipp b/src/uvw/thread.ipp
@@ -59,12 +59,8 @@ UVW_INLINE bool thread::run(create_flags opts, std::size_t stack) noexcept {
 }
 
 UVW_INLINE bool thread::join() noexcept {
-    if(joinable) {
-        joinable = false;
-        return (0 == uv_thread_join(raw()));
-    }
-
-    return true;
+    const auto was_joinable = std::exchange(joinable, false);
+    return was_joinable ? (0 == uv_thread_join(raw())) : true;
 }
 
 UVW_INLINE thread_local_storage::thread_local_storage(loop::token token, std::shared_ptr<loop> ref) noexcept

Original file line number	Diff line number	Diff line change
`@@ -59,12 +59,8 @@ UVW_INLINE bool thread::run(create_flags opts, std::size_t stack) noexcept {`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`UVW_INLINE bool thread::join() noexcept {`
`62`		`- if(joinable) {`
`63`		`- joinable = false;`
`64`		`- return (0 == uv_thread_join(raw()));`
`65`		`- }`
`66`		`-`
`67`		`- return true;`
	`62`	`+ const auto was_joinable = std::exchange(joinable, false);`
	`63`	`+ return was_joinable ? (0 == uv_thread_join(raw())) : true;`
`68`	`64`	`}`
`69`	`65`
`70`	`66`	`UVW_INLINE thread_local_storage::thread_local_storage(loop::token token, std::shared_ptr<loop> ref) noexcept`