-
Notifications
You must be signed in to change notification settings - Fork 6
PLAT-7450 Add singlestoredb_team resource and datasource #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
457bc97 to
bb302a5
Compare
bb302a5 to
7333cb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new SingleStoreDB teams resource and related data sources with full CRUD support, additional utility functions, tests, and documentation updates.
- Adds team-related functions in utility and converters packages.
- Implements the team resource and data source (get and list) along with corresponding test cases.
- Updates provider registration, examples, and docs for teams.
Reviewed Changes
Copilot reviewed 14 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/provider/util/util.go | Added SubtractListValues helper function. |
| internal/provider/util/converters.go | Added ParseUUIDList function to convert string slices to UUID slices. |
| internal/provider/testutil/updatableconfig.go | Added team resource and datasource update helpers. |
| internal/provider/teams/resource_test.go | Added CRUD tests for teams; contains typos in variable names. |
| internal/provider/teams/resource.go | Introduces the team resource implementation and its helper functions. |
| internal/provider/teams/list_test.go | Adds tests for the teams list datasource; includes a header value bug. |
| internal/provider/teams/list.go | Teams list datasource implementation. |
| internal/provider/teams/get_test.go | Added tests for getting a single team resource. |
| internal/provider/teams/get.go | Implements the team get datasource. |
| internal/provider/provider.go | Registers the teams resource and datasources with the provider. |
| examples/embed.go | Adds team resource and datasource examples. |
| docs/resources/team.md | Documentation for the team resource (example contains spelling errors). |
| docs/data-sources/teams.md and docs/data-sources/team.md | Documentation for the team datasources. |
Files not reviewed (3)
- examples/data-sources/singlestoredb_team/data-source.tf: Language not supported
- examples/data-sources/singlestoredb_teams/data-source.tf: Language not supported
- examples/resources/singlestoredb_team/resource.tf: Language not supported
abf9eff to
5e66ec6
Compare
5e66ec6 to
819e56b
Compare
noprysk-ua
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
Manual testing: