Skip to content

Conversation

@oyeliseiev-ua
Copy link
Contributor

@oyeliseiev-ua oyeliseiev-ua commented Apr 28, 2025

Manual testing:

  • Create: name/description/with users/with teams members
  • Update: add/remove user member, add/remove team member

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new SingleStoreDB teams resource and related data sources with full CRUD support, additional utility functions, tests, and documentation updates.

  • Adds team-related functions in utility and converters packages.
  • Implements the team resource and data source (get and list) along with corresponding test cases.
  • Updates provider registration, examples, and docs for teams.

Reviewed Changes

Copilot reviewed 14 out of 17 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
internal/provider/util/util.go Added SubtractListValues helper function.
internal/provider/util/converters.go Added ParseUUIDList function to convert string slices to UUID slices.
internal/provider/testutil/updatableconfig.go Added team resource and datasource update helpers.
internal/provider/teams/resource_test.go Added CRUD tests for teams; contains typos in variable names.
internal/provider/teams/resource.go Introduces the team resource implementation and its helper functions.
internal/provider/teams/list_test.go Adds tests for the teams list datasource; includes a header value bug.
internal/provider/teams/list.go Teams list datasource implementation.
internal/provider/teams/get_test.go Added tests for getting a single team resource.
internal/provider/teams/get.go Implements the team get datasource.
internal/provider/provider.go Registers the teams resource and datasources with the provider.
examples/embed.go Adds team resource and datasource examples.
docs/resources/team.md Documentation for the team resource (example contains spelling errors).
docs/data-sources/teams.md and docs/data-sources/team.md Documentation for the team datasources.
Files not reviewed (3)
  • examples/data-sources/singlestoredb_team/data-source.tf: Language not supported
  • examples/data-sources/singlestoredb_teams/data-source.tf: Language not supported
  • examples/resources/singlestoredb_team/resource.tf: Language not supported

Copy link
Collaborator

@noprysk-ua noprysk-ua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@oyeliseiev-ua oyeliseiev-ua merged commit 84dc580 into master Jun 13, 2025
5 checks passed
@oyeliseiev-ua oyeliseiev-ua deleted the PLAT-7450 branch June 13, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants