Pluginslib #215
Open
Pluginslib #215
+1,013
−782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- find_references.ts: Replace manual panel/navigation state with lib helpers - search_replace.ts: Replace manual panel/navigation state with lib helpers - diagnostics_panel.ts: Move to tests/plugins since it uses dummy sample data This reduces boilerplate by centralizing panel lifecycle and navigation state management in plugins/lib. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Plugins should be loaded relative to the executable's real path (resolving symlinks), not the user's working directory. This fixes the issue where `fresh /some/project` wouldn't find plugins. Search order for main plugins: 1. Next to executable (for cargo-dist installations) 2. Walk up from executable to find `target` dir, then check repo root (handles target/debug, target/release, and target/debug/deps for tests) Additionally, project-specific plugins are loaded from the working directory's `plugins/` folder (after main plugins). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- test_command_palette_down_no_wraparound: Use more specific filter "save file a" to avoid matching "Plugin Demo: Save File" from welcome plugin - test_buffer_modified_clears_after_save: Update assertion to account for git_gutter also being loaded (from main plugins dir). The test now verifies indicators don't increase after save, rather than requiring them to be zero. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Now that all plugins load from the main plugins directory, the command palette shows more commands (Plugin Demo, Search and Replace) and buffer modified indicators appear for edited files. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
The find_references.ts plugin imports from plugins/lib/, so tests that copy this plugin to a temp directory must also copy the lib. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need fixing:
FAIL [ 7.444s] fresh-editor::e2e_tests e2e::gutter::test_buffer_modified_clears_after_undo_on_same_line
FAIL [ 6.222s] fresh-editor::e2e_tests e2e::gutter::test_buffer_modified_single_line_in_multi_line_file
FAIL [ 4.071s] fresh-editor::e2e_tests e2e::prompt::test_save_as_relative_path