Skip to content

Commit 5fb2584

Browse files
sinelawclaude
andcommitted
Fix linux packages not included in GitHub release
Move custom-linux-packages job to run before host by using global-artifacts-jobs instead of host-jobs. This ensures the .deb and .rpm packages are available when the host job downloads artifacts-* and uploads them to the GitHub Release. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent 05c97b6 commit 5fb2584

File tree

2 files changed

+13
-14
lines changed

2 files changed

+13
-14
lines changed

.github/workflows/release.yml

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -211,14 +211,24 @@ jobs:
211211
path: |
212212
${{ steps.cargo-dist.outputs.paths }}
213213
${{ env.BUILD_MANIFEST_NAME }}
214+
215+
custom-linux-packages:
216+
needs:
217+
- plan
218+
- build-local-artifacts
219+
uses: ./.github/workflows/linux-packages.yml
220+
with:
221+
plan: ${{ needs.plan.outputs.val }}
222+
secrets: inherit
214223
# Determines if we should publish/announce
215224
host:
216225
needs:
217226
- plan
218227
- build-local-artifacts
219228
- build-global-artifacts
229+
- custom-linux-packages
220230
# Only run if we're "publishing", and only if plan, local and global didn't fail (skipped is fine)
221-
if: ${{ always() && needs.plan.result == 'success' && needs.plan.outputs.publishing == 'true' && (needs.build-global-artifacts.result == 'skipped' || needs.build-global-artifacts.result == 'success') && (needs.build-local-artifacts.result == 'skipped' || needs.build-local-artifacts.result == 'success') }}
231+
if: ${{ always() && needs.plan.result == 'success' && needs.plan.outputs.publishing == 'true' && (needs.build-global-artifacts.result == 'skipped' || needs.build-global-artifacts.result == 'success') && (needs.custom-linux-packages.result == 'skipped' || needs.custom-linux-packages.result == 'success') && (needs.build-local-artifacts.result == 'skipped' || needs.build-local-artifacts.result == 'success') }}
222232
env:
223233
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
224234
runs-on: "ubuntu-22.04"
@@ -278,21 +288,10 @@ jobs:
278288
279289
gh release create "${{ needs.plan.outputs.tag }}" --target "$RELEASE_COMMIT" $PRERELEASE_FLAG --title "$ANNOUNCEMENT_TITLE" --notes-file "$RUNNER_TEMP/notes.txt" artifacts/*
280290
281-
custom-linux-packages:
282-
needs:
283-
- plan
284-
- build-local-artifacts
285-
- build-global-artifacts
286-
uses: ./.github/workflows/linux-packages.yml
287-
with:
288-
plan: ${{ needs.plan.outputs.val }}
289-
secrets: inherit
290-
291291
announce:
292292
needs:
293293
- plan
294294
- host
295-
- custom-linux-packages
296295
# use "always() && ..." to allow us to wait for all publish jobs while
297296
# still allowing individual publish jobs to skip themselves (for prereleases).
298297
# "host" however must run to completion, no skipping allowed!

dist-workspace.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,5 @@ install-updater = false
1919
include = ["plugins/"]
2020
# A namespace to use when publishing this package to the npm registry
2121
npm-scope = "@fresh-editor"
22-
# Host jobs to run in CI
23-
host-jobs = ["./linux-packages"]
22+
# Custom jobs to build .deb and .rpm packages (runs before host uploads artifacts)
23+
global-artifacts-jobs = ["./linux-packages"]

0 commit comments

Comments
 (0)