v11.0.2

Author: sidneys

.appveyor.yml

@@ -23,8 +23,7 @@ install:
   - cmd: echo 🔧 Preparing Build Environment (Git)
   - cmd: git config --global core.autocrlf input
   - cmd: echo 🔧 Preparing Build Environment (Node.js)
-  - ps: Update-NodeJsInstallation 13.7.0
-  - cmd: npm --global update npm
+  - ps: Update-NodeJsInstallation 14.8.0 x64
   - cmd: npm --global install yarn
 
 before_build:

.travis.yml

@@ -47,7 +47,7 @@ addons:
 before_install:
   - echo "🔧 Preparing Build Environment (Node.js)"
   - curl -o- https://raw.githubusercontent.com/creationix/nvm/master/install.sh | NVM_DIR="${HOME}"/.nvm sh
-  - source "${HOME}"/.nvm/nvm.sh && nvm install 13.7.0 && nvm use 13.7.0
+  - source "${HOME}"/.nvm/nvm.sh && nvm install 14.8.0 && nvm use 14.8.0
   - npm --global update npm
   - npm --global install yarn
 

RELEASENOTES.json

@@ -1,16 +1,51 @@
 {
+    "11.0.2": {
+        "💎 improvements": [
+            "adds notification sound effects (102) from Google Sounds v2.3",
+            "reduces application size by ~45%, installer size by ~30%",
+            "upgrades notification thumbnail generator backend (pb-for-desktop-besticon.herokuapp.com)",
+            "migrates some non-user-facing components to Electron v10 compatibility (@electron/remote)",
+            "improves system-wide dark mode support (macOS 10.15)",
+            "multiple user interface quality improvements",
+            "various stability and performance improvements"
+        ],
+        "🚨 fixes": [
+            "fixes notification thumbnail image download and rendering issues",
+            "addresses various ipc-communication issues with regards to some upstream breaking changes",
+            "satisfy requirements of the v8 structured clone algorithm requirements",
+            "address audio playback issues with 'file://' protocol",
+            "fixes 'push could not be updated' issues",
+            "adhere cors configuration to match changed upstream (electron) configuration defaults",
+            "adds fix for [Error with 'Show PB for Desktop' menu, MacOS Catalina 10.15.2](https://github.com/sidneys/pb-for-desktop/issues/117) contributed by [MockingMagician](https://github.com/MockingMagician)",
+            "adds fix for [Cannot open main window](https://github.com/sidneys/pb-for-desktop/issues/116) contributed by [MockingMagician](https://github.com/MockingMagician)"
+        ],
+        "📒 documentation": [
+            "amends notification filter usage hints (filter-template.txt)",
+            "extends `jsdoc` documentation coverage"
+        ],
+        "👷 internals": [
+            "upgrades `electron` to `v9.2.1`",
+            "migrates `electron` APIs to v9",
+            "upgrades `nodejs` on ci backend",
+            "upgrades local `node_modules`",
+            "upgrades third-party `node_modules`",
+            "improves readability of log messages"
+        ]
+    },
     "10.5.0": {
         "💎 improvements": [
-            "enhances auto-update user interaction flow"
+            "enhances auto-update user interaction flow",
+            "enhances installer (Windows)"
         ],
         "🚨 fixes": [
             "fixes upstream auto-update issue which prevented update installation (https://github.com/electron/electron/pull/21645)",
             "fixes application restart, reconnecting to Pushbullet",
             "fixes application reset, user data removal",
-            "fixes macOS 10.15 Catalina startup issue with .zip-based packages & auto-updater payloads (https://github.com/sidneys/pb-for-desktop/issues/113) (macOS)"
+            "fixes macOS 10.15 Catalina startup issue with .zip-based packages & auto-updater payloads (https://github.com/sidneys/pb-for-desktop/issues/113) (macOS)",
+            "fixes Google 2FA sign-in issue (https://github.com/sidneys/pb-for-desktop/issues/114)"
         ],
         "👷 internals": [
-            "upgrades `electron` to `v7.1.9`",
+            "upgrades `electron` to `v8.2.0`",
             "upgrades local `node_modules`",
             "upgrades third-party `node_modules`"
         ]
@@ -822,4 +857,4 @@
             "Build system upgrade"
         ]
     }
-}
+}

app/html/main.html

@@ -31,11 +31,14 @@
 
 <!-- webview -->
 <webview id="webview"
-        disablewebsecurity="true"
-        partition="persist:app"
-        preload="../scripts/renderer-process/webviews/pushbullet-webview.js"
-        useragent="Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:70.0) Gecko/20100101 Firefox/70.0"
-        src="https://www.pushbullet.com">
+         src="https://www.pushbullet.com"
+         preload="../scripts/renderer-process/webviews/pushbullet-webview.js"
+         partition="persist:app"
+         disablewebsecurity="true"
+         enableblinkfeatures="OutOfBlinkCors"
+         enableremotemodule="true"
+         useragent="Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:70.0) Gecko/20100101 Firefox/70.0"
+>
 </webview>
 <!-- webview-->
 

app/scripts/main-process/components/globals.js

@@ -48,7 +48,7 @@ global.appFilesystem = {
     resources: process.resourcesPath,
     settings: path.join(path.dirname(electronSettings.file()), `${packageJson.name}.json`),
     sounds: path.join(appRootPathDirectory, 'sounds').replace('app.asar', 'app.asar.unpacked'),
-    tempdir: (isDebug && process.defaultApp) ? appRootPathDirectory : os.tmpdir(),
+    tempdir: (isDebug && process.defaultApp) ? path.join(appRootPathDirectory, 'temp') : os.tmpdir(),
     logs: logger.getConfiguration().logfile,
     icon: path.join(appRootPathDirectory, 'icons', platformTools.type, `icon${platformTools.iconImageExtension(platformTools.type)}`)
 }

app/scripts/main-process/index.js

@@ -12,7 +12,7 @@ const events = require('events')
  * @constant
  */
 const electron = require('electron')
-const { app, BrowserWindow, systemPreferences } = electron
+const { app, BrowserWindow, nativeTheme, session } = electron
 
 /**
  * Modules (Local)
@@ -42,6 +42,13 @@ app.commandLine.appendSwitch('autoplay-policy', 'no-user-gesture-required')
  */
 // app.commandLine.appendSwitch('disable-renderer-backgrounding')
 
+/**
+ * HOTFIX
+ * Electron 9 webSecurity option no longer disables CORS
+ * @see {@link https://github.com/electron/electron/issues/23664}
+ */
+app.commandLine.appendSwitch('disable-features', 'OutOfBlinkCors')
+
 /**
  * HOTFIX
  * Electron Security Warning
@@ -130,13 +137,25 @@ app.on('second-instance', () => {
  */
 app.once('ready', () => {
     logger.debug('app#ready')
+
+    /**
+     * HOTFIX
+     * Register file:// protocol for default session
+     * @see {@link https://www.electronjs.org/docs/api/protocol}
+     * @see {@link https://github.com/electron/electron/issues/23757#issuecomment-640146333}
+     */
+    const appSession = session.fromPartition('persist:app')
+    appSession.protocol.registerFileProtocol('file', (request, callback) => {
+        const filePath = decodeURI(request.url.replace('file:///', ''))
+        callback(filePath)
+    })
 })
 
 
 /**
- * @listens Electron.systemPreferences:appearance-changed
+ * @listens Electron.nativeTheme:updated
  */
-systemPreferences.on('appearance-changed', (newAppearance) => {
-    logger.debug('systemPreferences#appearance-changed', 'newAppearance:', newAppearance)
+nativeTheme.on('updated', () => {
+    logger.debug('nativeTheme#updated', 'nativeTheme.themeSource', nativeTheme.themeSource)
 })