Skip to content

Commit 17699a6

Browse files
committed
test: add sarif validation
1 parent c34cbbf commit 17699a6

File tree

3 files changed

+77
-0
lines changed

3 files changed

+77
-0
lines changed

go.mod

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ require (
99
github.com/mozilla/tls-observatory v0.0.0-20250923143331-eef96233227e
1010
github.com/onsi/ginkgo/v2 v2.27.2
1111
github.com/onsi/gomega v1.38.2
12+
github.com/santhosh-tekuri/jsonschema/v6 v6.0.2
1213
github.com/stretchr/testify v1.11.1
1314
golang.org/x/crypto v0.43.0
1415
golang.org/x/text v0.30.0

go.sum

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,8 @@ github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSs
9191
github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
9292
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
9393
github.com/dgrijalva/jwt-go v3.2.0+incompatible/go.mod h1:E3ru+11k8xSBh+hMPgOLZmtrrCbhqsmaPHjLKYnJCaQ=
94+
github.com/dlclark/regexp2 v1.11.0 h1:G/nrcoOa7ZXlpoa/91N3X7mM3r8eIlMBBJZvsz/mxKI=
95+
github.com/dlclark/regexp2 v1.11.0/go.mod h1:DHkYz0B9wPfa6wondMfaivmHpzrQ3v9q8cnmRbL6yW8=
9496
github.com/dustin/go-humanize v0.0.0-20171111073723-bb3d318650d4/go.mod h1:HtrtbFcZ19U5GC7JDqmcUSB87Iq5E25KnS6fMYU6eOk=
9597
github.com/dustin/go-humanize v1.0.0/go.mod h1:HtrtbFcZ19U5GC7JDqmcUSB87Iq5E25KnS6fMYU6eOk=
9698
github.com/envoyproxy/go-control-plane v0.9.0/go.mod h1:YTl/9mNaCwkRvm6d1a2C3ymFceY/DCBVvsKhRF0iEA4=
@@ -340,6 +342,8 @@ github.com/rogpeppe/go-internal v1.13.1/go.mod h1:uMEvuHeurkdAXX61udpOXGD/AzZDWN
340342
github.com/rs/cors v1.7.0/go.mod h1:gFx+x8UowdsKA9AchylcLynDq+nNFfI8FkUZdN/jGCU=
341343
github.com/russross/blackfriday v1.5.2/go.mod h1:JO/DiYxRf+HjHt06OyowR9PTA263kcR/rfWxYHBV53g=
342344
github.com/russross/blackfriday/v2 v2.0.1/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
345+
github.com/santhosh-tekuri/jsonschema/v6 v6.0.2 h1:KRzFb2m7YtdldCEkzs6KqmJw4nqEVZGK7IN2kJkjTuQ=
346+
github.com/santhosh-tekuri/jsonschema/v6 v6.0.2/go.mod h1:JXeL+ps8p7/KNMjDQk3TCwPpBy0wYklyWTfbkIzdIFU=
343347
github.com/sergi/go-diff v1.1.0/go.mod h1:STckp+ISIX8hZLjrqAeVduY0gWCT9IjLuqbuNXdaHfM=
344348
github.com/shurcooL/sanitized_anchor_name v1.0.0/go.mod h1:1NzhyTcUVG4SuEtjjoZeVRXNmyL/1OwPU0+IJeTBvfc=
345349
github.com/sirupsen/logrus v1.2.0/go.mod h1:LxeOpSwHxABJmUn/MG1IvRgCAasNZTLOkJPxbbu5VWo=

report/sarif/sarif_test.go

Lines changed: 72 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,80 @@
11
package sarif_test
22

33
import (
4+
"bufio"
45
"bytes"
6+
"encoding/json"
7+
"fmt"
8+
"net/http"
59
"regexp"
10+
"sync"
11+
"time"
612

713
. "github.com/onsi/ginkgo/v2"
814
. "github.com/onsi/gomega"
15+
"github.com/santhosh-tekuri/jsonschema/v6"
916

1017
"github.com/securego/gosec/v2"
1118
"github.com/securego/gosec/v2/issue"
1219
"github.com/securego/gosec/v2/report/sarif"
1320
)
1421

22+
var (
23+
sarifSchemaOnce sync.Once
24+
sarifSchema *jsonschema.Schema
25+
sarifSchemaErr error
26+
sarifSchemaClient = &http.Client{Timeout: 30 * time.Second}
27+
)
28+
29+
func validateSarifSchema(report *sarif.Report) error {
30+
GinkgoHelper()
31+
sarifSchemaOnce.Do(func() {
32+
resp, err := sarifSchemaClient.Get(sarif.Schema)
33+
if err != nil {
34+
sarifSchemaErr = fmt.Errorf("fetch sarif schema: %w", err)
35+
return
36+
}
37+
defer resp.Body.Close()
38+
39+
if resp.StatusCode != http.StatusOK {
40+
sarifSchemaErr = fmt.Errorf("fetch sarif schema: unexpected status %s", resp.Status)
41+
return
42+
}
43+
44+
schema, err := jsonschema.UnmarshalJSON(resp.Body)
45+
if err != nil {
46+
sarifSchemaErr = fmt.Errorf("error unmarshaling schema: %w", err)
47+
return
48+
}
49+
50+
compiler := jsonschema.NewCompiler()
51+
if err := compiler.AddResource(sarif.Schema, schema); err != nil {
52+
sarifSchemaErr = fmt.Errorf("compile sarif schema: %w", err)
53+
return
54+
}
55+
56+
sarifSchema, sarifSchemaErr = compiler.Compile(sarif.Schema)
57+
})
58+
59+
if sarifSchemaErr != nil {
60+
return sarifSchemaErr
61+
}
62+
63+
// Marshal the report to JSON
64+
v, err := json.MarshalIndent(report, "", "\t")
65+
if err != nil {
66+
return err
67+
}
68+
69+
// Unmarshal into any for schema validation
70+
data, err := jsonschema.UnmarshalJSON(bufio.NewReader(bytes.NewReader(v)))
71+
if err != nil {
72+
return err
73+
}
74+
75+
return sarifSchema.Validate(data)
76+
}
77+
1578
var _ = Describe("Sarif Formatter", func() {
1679
BeforeEach(func() {
1780
})
@@ -23,6 +86,9 @@ var _ = Describe("Sarif Formatter", func() {
2386
result := buf.String()
2487
Expect(err).ShouldNot(HaveOccurred())
2588
Expect(result).To(ContainSubstring("\"results\": ["))
89+
sarifReport, err := sarif.GenerateReport([]string{}, reportInfo)
90+
Expect(err).ShouldNot(HaveOccurred())
91+
Expect(validateSarifSchema(sarifReport)).To(Succeed())
2692
})
2793

2894
It("sarif formatted report should contain the suppressed results", func() {
@@ -57,6 +123,9 @@ var _ = Describe("Sarif Formatter", func() {
57123

58124
hasSuppressions, _ := regexp.MatchString(`"suppressions": \[(\s*){`, result)
59125
Expect(hasSuppressions).To(BeTrue())
126+
sarifReport, err := sarif.GenerateReport([]string{}, reportInfo)
127+
Expect(err).ShouldNot(HaveOccurred())
128+
Expect(validateSarifSchema(sarifReport)).To(Succeed())
60129
})
61130
It("sarif formatted report should contain the formatted one line code snippet", func() {
62131
ruleID := "G101"
@@ -84,6 +153,7 @@ var _ = Describe("Sarif Formatter", func() {
84153
sarifReport, err := sarif.GenerateReport([]string{}, reportInfo)
85154
Expect(err).ShouldNot(HaveOccurred())
86155
Expect(sarifReport.Runs[0].Results[0].Locations[0].PhysicalLocation.Region.Snippet.Text).Should(Equal(expectedCode))
156+
Expect(validateSarifSchema(sarifReport)).To(Succeed())
87157
})
88158
It("sarif formatted report should contain the formatted multiple line code snippet", func() {
89159
ruleID := "G101"
@@ -111,6 +181,7 @@ var _ = Describe("Sarif Formatter", func() {
111181
sarifReport, err := sarif.GenerateReport([]string{}, reportInfo)
112182
Expect(err).ShouldNot(HaveOccurred())
113183
Expect(sarifReport.Runs[0].Results[0].Locations[0].PhysicalLocation.Region.Snippet.Text).Should(Equal(expectedCode))
184+
Expect(validateSarifSchema(sarifReport)).To(Succeed())
114185
})
115186
It("sarif formatted report should have proper rule index", func() {
116187
rules := []string{"G404", "G101", "G102", "G103"}
@@ -171,6 +242,7 @@ var _ = Describe("Sarif Formatter", func() {
171242
driverRuleIndexes[rule.ID] = ruleIndex
172243
}
173244
Expect(resultRuleIndexes).Should(Equal(driverRuleIndexes))
245+
Expect(validateSarifSchema(sarifReport)).To(Succeed())
174246
})
175247
})
176248
})

0 commit comments

Comments
 (0)