tests: Remove unused bad_with_status() function

Author: Turbo87

src/tests/all.rs

@@ -11,7 +11,7 @@ extern crate serde;
 #[macro_use]
 extern crate serde_json;
 
-use crate::util::{Bad, RequestHelper, TestApp};
+use crate::util::{RequestHelper, TestApp};
 use cargo_registry::{
     models::{Crate, CrateOwner, Dependency, NewCategory, NewTeam, NewUser, Team, User, Version},
     schema::crate_owners,
@@ -182,14 +182,6 @@ fn req(method: conduit::Method, path: &str) -> MockRequest {
     request
 }
 
-fn bad_resp(r: &mut AppResponse) -> Option<Bad> {
-    let bad = json::<Bad>(r);
-    if bad.errors.is_empty() {
-        return None;
-    }
-    Some(bad)
-}
-
 fn json<T>(r: &mut AppResponse) -> T
 where
     for<'de> T: serde::Deserialize<'de>,

src/tests/util.rs

@@ -554,11 +554,6 @@ pub struct Error {
     pub detail: String,
 }
 
-#[derive(Deserialize)]
-pub struct Bad {
-    pub errors: Vec<Error>,
-}
-
 /// A type providing helper methods for working with responses
 #[must_use]
 pub struct Response<T> {
@@ -591,18 +586,6 @@ where
         crate::json(&mut self.response)
     }
 
-    /// Assert the response status code and deserialze into a list of errors
-    ///
-    /// Cargo endpoints return a status 200 on error instead of 400.
-    #[track_caller]
-    pub fn bad_with_status(&mut self, expected: StatusCode) -> Bad {
-        assert_eq!(self.response.status(), expected);
-        match crate::bad_resp(&mut self.response) {
-            None => panic!("ok response: {:?}", self.response.status()),
-            Some(b) => b,
-        }
-    }
-
     #[track_caller]
     pub fn assert_status(&self, status: StatusCode) -> &Self {
         assert_eq!(status, self.response.status());