Skip to content

Conversation

@morgoth
Copy link
Member

@morgoth morgoth commented Dec 5, 2024

No description provided.

@rosa
Copy link
Member

rosa commented Dec 5, 2024

Hi @morgoth, thanks for this! But this was not supported on purpose, as a deterrent to avoid people setting secret as their password, forcing having to use Rails credentials and providing an easy way to set those via a command.

@morgoth
Copy link
Member Author

morgoth commented Dec 5, 2024

Not being able to set it by hand as all other configs would make people confuse when they try it (as me ;-).
Also I can imagine people setting secrets via env variable, which for them it won't be possible to use this feature.

@rosa
Copy link
Member

rosa commented Dec 5, 2024

I think the README explains it, in case someone is confused 🤔 I'll wait to see if this actually becomes a problem before changing it.

@dvose
Copy link

dvose commented May 23, 2025

@rosa can we please merge this for env variable? Our team does not use credentials.yml for secrets. Perhaps rewording the README to explicitly use env variables in the example instead of hardcoding the creds? Current workaround is to re-implement basic auth in a custom controller.

@rosa
Copy link
Member

rosa commented Jul 11, 2025

Ok, let's change this. Sorry for the delay, and thanks for your patience 🙏

@rosa rosa merged commit b11ef80 into rails:main Jul 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants