Fixes situtation in which non empty folder could be removed #1566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qarmin
force-pushed
the
fixes_i_dont_know
branch
from
0118f58 to
c9a4b83
Compare
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses several issues in the Krokiet application by adding folder validation, CLI argument support, and library updates. The changes focus on improving empty folder removal safety, adding command-line interface capabilities, and updating dependencies.
- Adds validation to prevent deletion of folders that are no longer empty since scanning
- Introduces CLI argument processing to automatically set included/excluded/referenced folders
- Replaces pdf-rs with lopdf library for better PDF handling and reduced dependencies
Reviewed Changes
Copilot reviewed 26 out of 31 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| krokiet/src/cli.rs | New CLI argument parser with folder validation and help/version commands |
| krokiet/src/settings.rs | Modified settings loading to support CLI-provided folders via reserved preset |
| czkawka_core/src/common.rs | Added folder validation function to check if folders contain only empty subfolders |
| czkawka_core/src/tools/broken_files.rs | Replaced pdf-rs with lopdf for PDF validation |
| misc/find_unused_translations.py | New Python script to find unused translation keys |
Files not reviewed (4)
- misc/.idea/czkawka.iml: Language not supported
- misc/.idea/modules.xml: Language not supported
- misc/.idea/vcs.xml: Language not supported
- misc/.idea/workspace.xml: Language not supported
Comments suppressed due to low confidence (1)
krokiet/src/settings.rs:40
- The constant name has a typo: 'RESERVER' should be 'RESERVED'.
pub const RESERVER_PRESET_IDX: i32 = PRESET_NUMBER as i32 - 1; // 10 normal presets + 1 reserved preset for custom settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1560 (probably - I cannot reproduce problem, but added new validations before deleting
Closes #1222
Closes #1512
Closes #861
Closes #375
krokiet --help