fix 'Too many open files' error and improve error message #2922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change addresses an 'OSError: [Errno 24] Too many open files' that occurs when running tox in parallel in projects that use virtualenv. The error is caused by a file descriptor leak in virtualenv's locking mechanism. This change fixes the leak by ensuring that file locks are properly released. This change also improves the error message that is displayed when this error occurs, to provide more context and suggest possible solutions. A new test case has been added to reproduce the error in a controlled way and verify the fix. The test now uses `@pytest.mark.skipif` to be skipped on Windows. Fixes pypa#2834 Signed-off-by: Emre Şafak <[email protected]>
This change addresses an 'OSError: [Errno 24] Too many open files' that occurs when running tox in parallel in projects that use virtualenv. The error is caused by a file descriptor leak in virtualenv's locking mechanism. This change fixes the leak by ensuring that file locks are properly released. This change also improves the error message that is displayed when this error occurs, to provide more context and suggest possible solutions. A new test case has been added to reproduce the error in a controlled way and verify the fix. The test now uses `@pytest.mark.skipif` to be skipped on Windows and the `resource` module is imported inside the test function to avoid `ImportError` on Windows.
for more information, see https://pre-commit.ci
Signed-off-by: Emre Şafak <[email protected]>
Signed-off-by: Bernát Gábor <[email protected]>
gaborbernat
previously approved these changes
Aug 1, 2025
Signed-off-by: Emre Şafak <[email protected]>
auto-merge was automatically disabled
August 1, 2025 16:18
Head branch was pushed to by a user without write access
gaborbernat
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses an 'OSError: [Errno 24] Too many open files' that occurs when running tox in parallel in projects that use virtualenv.
The error is caused by a file descriptor leak in virtualenv's locking mechanism. This change fixes the leak by ensuring that file locks are properly released.
This change also improves the error message that is displayed when this error occurs, to provide more context and suggest possible solutions.
A new test case has been added to reproduce the error in a controlled way and verify the fix. The test now uses
@pytest.mark.skipifto be skipped on Windows.Fixes #2834
tox -e fix)docs/changelogfolder