Skip to content

Commit 9770151

Browse files
committed
fix: 'uc deploy' push image to all machines if x-machines is not specified
1 parent 89db50e commit 9770151

File tree

2 files changed

+6
-10
lines changed

2 files changed

+6
-10
lines changed

cmd/uncloud/deploy.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -127,9 +127,9 @@ func runDeploy(ctx context.Context, uncli *cli.CLI, opts deployOptions) error {
127127
var pushOpts client.PushImageOptions
128128
if machines, ok := s.Extensions[compose.MachinesExtensionKey].(compose.MachinesSource); ok {
129129
pushOpts.Machines = machines
130-
if len(machines) == 0 {
131-
pushOpts.AllMachines = true
132-
}
130+
}
131+
if len(pushOpts.Machines) == 0 {
132+
pushOpts.AllMachines = true
133133
}
134134

135135
boldStyle := lipgloss.NewStyle().Bold(true)

website/compose.yaml

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,4 @@
11
services:
2-
dep:
3-
build: .
4-
image: myapp:{{gitdate "20060102-150405" "Local"}}.{{gitsha 7}}
5-
x-machines:
6-
- dev1
7-
82
uncloud-website:
93
image: ghcr.io/psviderski/uncloud-website
104
build:
@@ -18,6 +12,8 @@ services:
1812
user: nobody
1913
x-ports:
2014
- uncloud.run:8000/https
21-
scale: 1
15+
scale: 2
16+
# TODO: remove x-machines after destroying uc-prod-us1
2217
x-machines:
18+
- uc-prod-ap1
2319
- uc-prod-us2

0 commit comments

Comments
 (0)