Use FES internationalization within the minor version

[ksen0]

Addresses #7813

• npm run lint passes
• Inline reference is included / updated
• Unit tests are included / updated

const version = '1.11.7';
const loadPath = 'https://cdn.jsdelivr.net/npm/p5@' + version.replace(/^(\d+\.\d+)\.\d+.*$/, '$1') + '/translations/{{lng}}/{{ns}}.json';
console.log(loadPath);
// https://cdn.jsdelivr.net/npm/[email protected]/translations/{{lng}}/{{ns}}.json
// will become https://cdn.jsdelivr.net/npm/[email protected]/translations/es/translation.json which exists

[limzykenneth]

Sorry this took awhile to get to. One suggestion on alternative approach.

[IIITM-Jay]

Hi @ksen0 , @limzykenneth just a thought here.
Will it be a better idea to separate out the base CDN URL here and the version parsing logic for better readability and reusability too, and then compose the final loadPath. I was thinking to encapsulate it like below:

const getCDNPath = (() => {
  const base = 'https://cdn.jsdelivr.net/npm/p5@';
  const version = constants.VERSION.replace(/^(\d+\.\d+)\.\d+.*$/, '$1');
  return `${base}${version}`;
})();

[limzykenneth]

I'm not sure it's worth to split it out in this way, especially also encapsulating it in a function, if needed, just a string interpolation should suffice as well.

`https://cdn.jsdelivr.net/npm/p5@${constants.VERSION.replace(/^(\d+\.\d+)\.\d+.*$/, '$1')}`

[IIITM-Jay]

Yes, I see that there's no broader scope for reusability in this case, so I agree — using direct string interpolation is sufficient and keeps it clean.

[IIITM-Jay]

My initial thought was that separating the base URL and version logic might help with readability and clarity, especially if more dynamic paths were ever added later. But given the current usage, simplicity could be more prioritized.

Thanks for sharing this!

[IIITM-Jay]

and then here, we could compose it like

loadPath: `${getCDNPath}/translations/{{lng}}/{{ns}}.json`

[IIITM-Jay]

and then I think with string interpolation we could simply write with one liner change:

loadPath: `https://cdn.jsdelivr.net/npm/p5@${constants.VERSION.replace(/^(\d+\.\d+)\.\d+.*$/, '$1')}/translations/{{lng}}/{{ns}}.json`