Merge pull request #7765 from HughJacks/fix-fes-error

Fixed Error in FES prevents message from being shown, Prevented 'window' properties from being overwritten

Author: davepagurek

src/core/friendly_errors/fes_core.js

@@ -348,7 +348,7 @@ function fesCore(p5, fn){
         // actual name with correct capitalization doesnt exist in context,
         // and if the user-defined symbol is of the type function
         if (
-          fxns[lowercase] &&
+          fxns.hasOwnProperty(lowercase) &&
           !context[fxns[lowercase]] &&
           typeof context[prop] === 'function'
         ) {

src/core/main.js

@@ -137,10 +137,11 @@ class p5 {
         bindGlobal(p);
       }
 
+      const protectedProperties = ['constructor', 'length'];
       // Attach its properties to the window
       for (const p in this) {
         if (this.hasOwnProperty(p)) {
-          if(p[0] === '_') continue;
+          if(p[0] === '_' || protectedProperties.includes(p)) continue;
           bindGlobal(p);
         }
       }