DateTimeInstantiationRule - do not report warnings

Author: ondrejmirtes

src/Rules/DateTimeInstantiationRule.php

@@ -46,14 +46,6 @@ public function processNode(Node $node, Scope $scope): array
 		}
 		$lastErrors = DateTime::getLastErrors();
 		if ($lastErrors !== false) {
-			foreach ($lastErrors['warnings'] as $warning) {
-				$errors[] = RuleErrorBuilder::message(sprintf(
-					'Instantiating %s with %s produces a warning: %s',
-					(string) $node->class,
-					$dateString,
-					$warning
-				))->build();
-			}
 			foreach ($lastErrors['errors'] as $error) {
 				$errors[] = RuleErrorBuilder::message(sprintf(
 					'Instantiating %s with %s produces an error: %s',

tests/PHPStan/Rules/DateTimeInstantiationRuleTest.php

@@ -22,10 +22,10 @@ public function test(): void
 					'Instantiating DateTime with 2020.11.17 produces an error: Double time specification',
 					3,
 				],
-				[
+				/*[
 					'Instantiating DateTimeImmutable with asdfasdf produces a warning: Double timezone specification',
 					5,
-				],
+				],*/
 				[
 					'Instantiating DateTimeImmutable with asdfasdf produces an error: The timezone could not be found in the database',
 					5,
@@ -38,10 +38,10 @@ public function test(): void
 					'Instantiating DateTimeImmutable with 2020.11.18 produces an error: Double time specification',
 					17,
 				],
-				[
+				/*[
 					'Instantiating DateTime with 2020-04-31 produces a warning: The parsed date was invalid',
 					20,
-				],
+				],*/
 			]
 		);
 	}