Skip to content

Conversation

@wolfv
Copy link
Contributor

@wolfv wolfv commented Apr 6, 2020

Hi @p-ranav this is probably a bit controversial but I have modified the code so that a "unspecified" color is available (just the default color from the terminal) and made it the default.
I also removed the default of making the font bold.

Let me know if you don't want me to make these two things the default.

Maybe we can add a setting for bold, and italic?

@wolfv
Copy link
Contributor Author

wolfv commented Apr 6, 2020

ah btw very nice package, we'll be using it in the package manager mamba (and tabulate as well, most likely!)

@p-ranav
Copy link
Owner

p-ranav commented Apr 6, 2020

Sounds good. I'll add an option to each progress bar, something like:

option::FontStyles{FontStyle::bold, FontStyle::italic, FontStyle::crossed, ...}

That should make this setting more explicit.

Thanks!

@p-ranav p-ranav merged commit 562cb80 into p-ranav:master Apr 6, 2020
@p-ranav
Copy link
Owner

p-ranav commented Apr 6, 2020

Updated

Now you can explicitly specify font styles as needed.

@wolfv
Copy link
Contributor Author

wolfv commented Apr 6, 2020

very cool! I have made a recipe for conda-forge: conda-forge/staged-recipes#11230

please let me know if you're ok to be a co-maintainer :)

Cheers

@p-ranav
Copy link
Owner

p-ranav commented Apr 6, 2020

very cool! I have made a recipe for conda-forge: conda-forge/staged-recipes#11230

please let me know if you're ok to be a co-maintainer :)

Cheers

There's already one of these open for indicators: conda-forge/staged-recipes#11117

@wolfv wolfv deleted the add_color_unspecified branch April 7, 2020 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants