src: fix allow_slaac_only #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported by @nxhack at openwrt#131, allow_slaac_only was assigned an incorrect default value when it was moved from odhcp6c.c to config.c. Fixes: 1048fc4 ("reconfigure: move all configuration functions to a new file") Signed-off-by: Álvaro Fernández Rojas <[email protected]>
allow_slaac_only is declared as a boolean in the OpenWrt wiki and the script doesn't pass any value at all: https://github.com/openwrt/openwrt/blob/00c8b5c612d07e36ede1e9ebe2b44ba88fa90000/package/network/ipv6/odhcp6c/files/dhcpv6.sh#L94 Signed-off-by: Álvaro Fernández Rojas <[email protected]>
script_sync_delay is no longer updated with allow_slaac_only, so this isn't needed. Signed-off-by: Álvaro Fernández Rojas <[email protected]>
Noltari
force-pushed
the
fix-allow_slaac_only
branch
from
ad5b4c2 to
dc7dadf
Compare
Contributor
|
Just gotta fix that other boolean |
Noltari
force-pushed
the
fix-allow_slaac_only
branch
from
dc7dadf to
1f1a7c6
Compare
It's declared as a boolean in the OpenWrt wiki, and the package script doesn't pass any value. Signed-off-by: Álvaro Fernández Rojas <[email protected]>
Noltari
force-pushed
the
fix-allow_slaac_only
branch
from
1f1a7c6 to
1d6c4e7
Compare
Member
Author
@systemcrash which one? |
Contributor
|
OK. All good now! LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @systemcrash @nxhack @Alphix