refactor: OpenRewrite Recipe best practices

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.recipes.rewrite.OpenRewriteRecipeBestPractices?organizationId=T3BlblJld3JpdGU%3D

Co-authored-by: Moderne <[email protected]>

Author: timtebeek

src/main/resources/META-INF/rewrite/examples.yml

@@ -26,19 +26,17 @@ examples:
 
       class Test {
           void method(Logger logger) {
-            logger.entering("Test", "method");
-            logger.entering("Test", "method", "param");
-            logger.entering("Test", "method", new Object[]{"param1", "param2"});
+            logger.exiting("Test", "method");
+            logger.exiting("Test", "method", "result");
           }
       }
     after: |
       import org.apache.logging.log4j.Logger;
 
       class Test {
           void method(Logger logger) {
-            logger.traceEntry();
-            logger.traceEntry(null, "param");
-            logger.traceEntry(null, new Object[]{"param1", "param2"});
+            logger.traceExit();
+            logger.traceExit("result");
           }
       }
     language: java
@@ -53,17 +51,19 @@ examples:
 
       class Test {
           void method(Logger logger) {
-            logger.exiting("Test", "method");
-            logger.exiting("Test", "method", "result");
+            logger.entering("Test", "method");
+            logger.entering("Test", "method", "param");
+            logger.entering("Test", "method", new Object[]{"param1", "param2"});
           }
       }
     after: |
       import org.apache.logging.log4j.Logger;
 
       class Test {
           void method(Logger logger) {
-            logger.traceExit();
-            logger.traceExit("result");
+            logger.traceEntry();
+            logger.traceEntry(null, "param");
+            logger.traceEntry(null, new Object[]{"param1", "param2"});
           }
       }
     language: java
@@ -331,7 +331,8 @@ examples:
 - description: ''
   sources:
   - before: |
-      import java.util.logging.Level;import java.util.logging.Logger;
+      import java.util.logging.Level;
+      import java.util.logging.Logger;
 
       class Test {
           void method(Logger logger) {
@@ -732,26 +733,6 @@ examples:
       import java.util.logging.Level;
       import java.util.logging.Logger;
 
-      class Test {
-          void method(Logger logger, String param1) {
-              logger.log(Level.INFO, "INFO Log entry, param1: {0}", param1);
-          }
-      }
-    after: |
-      import org.slf4j.Logger;
-
-      class Test {
-          void method(Logger logger, String param1) {
-              logger.info("INFO Log entry, param1: {}", param1);
-          }
-      }
-    language: java
-- description: ''
-  sources:
-  - before: |
-      import java.util.logging.Level;
-      import java.util.logging.Logger;
-
       class Test {
           void method(Logger logger) {
               logger.finest("finest");
@@ -798,6 +779,26 @@ examples:
           }
       }
     language: java
+- description: ''
+  sources:
+  - before: |
+      import java.util.logging.Level;
+      import java.util.logging.Logger;
+
+      class Test {
+          void method(Logger logger, String param1) {
+              logger.log(Level.INFO, "INFO Log entry, param1: {0}", param1);
+          }
+      }
+    after: |
+      import org.slf4j.Logger;
+
+      class Test {
+          void method(Logger logger, String param1) {
+              logger.info("INFO Log entry, param1: {}", param1);
+          }
+      }
+    language: java
 ---
 type: specs.openrewrite.org/v1beta/example
 recipeName: org.openrewrite.java.logging.slf4j.Log4j1ToSlf4j1
@@ -806,19 +807,16 @@ examples:
   sources:
   - before: |
       import org.apache.log4j.Logger;
-      import org.apache.log4j.LogManager;
 
       class Test {
           Logger logger0 = Logger.getLogger(Test.class);
-          Logger logger1 = LogManager.getLogger(Test.class);
       }
     after: |
       import org.slf4j.Logger;
       import org.slf4j.LoggerFactory;
 
       class Test {
           Logger logger0 = LoggerFactory.getLogger(Test.class);
-          Logger logger1 = LoggerFactory.getLogger(Test.class);
       }
     language: java
 ---