Skip to content

Commit c185014

Browse files
committed
Do not reduce visibility of logger field in abstract class
1 parent e92940e commit c185014

File tree

2 files changed

+20
-1
lines changed

2 files changed

+20
-1
lines changed

src/main/java/org/openrewrite/java/logging/ChangeLoggersToPrivate.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434

3535
import static java.util.Collections.emptyList;
3636
import static java.util.stream.Collectors.toSet;
37+
import static org.openrewrite.java.tree.J.Modifier.Type.Abstract;
3738

3839
@EqualsAndHashCode(callSuper = false)
3940
@Value
@@ -76,7 +77,8 @@ public J.VariableDeclarations visitVariableDeclarations(J.VariableDeclarations m
7677
}
7778

7879
J.ClassDeclaration classDeclaration = parent.getValue();
79-
if (classDeclaration.getKind() == J.ClassDeclaration.Kind.Type.Interface) {
80+
if (classDeclaration.getKind() == J.ClassDeclaration.Kind.Type.Interface ||
81+
classDeclaration.hasModifier(Abstract)) {
8082
return mv;
8183
}
8284

src/test/java/org/openrewrite/java/logging/ChangeLoggersToPrivateTest.java

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,23 @@ interface Constants {
175175
);
176176
}
177177

178+
@Test
179+
void loggerInAbstractClassShouldNotChange() {
180+
rewriteRun(
181+
//language=java
182+
java(
183+
"""
184+
import org.slf4j.Logger;
185+
import org.slf4j.LoggerFactory;
186+
187+
abstract class Constants {
188+
Logger logger = LoggerFactory.getLogger(Constants.class);
189+
}
190+
"""
191+
)
192+
);
193+
}
194+
178195
@Test
179196
void localVariableLoggerShouldNotChange() {
180197
rewriteRun(

0 commit comments

Comments
 (0)