OpenRewrite recipe best practices

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.recipes.rewrite.OpenRewriteRecipeBestPractices?organizationId=QUxML09wZW4gU291cmNlL09wZW5SZXdyaXRl

Co-authored-by: Moderne <[email protected]>

Author: timtebeek

src/main/java/org/openrewrite/java/logging/slf4j/JulParameterizedArguments.java

@@ -28,11 +28,15 @@
 import org.openrewrite.java.search.UsesMethod;
 import org.openrewrite.java.tree.*;
 
-import java.util.*;
+import java.util.ArrayList;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
 import static java.util.Collections.emptyList;
+import static java.util.Collections.nCopies;
 import static java.util.Objects.requireNonNull;
 import static java.util.stream.Collectors.toList;
 
@@ -131,7 +135,7 @@ public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, Execu
 
                 // In case of logger.log(Level.INFO, "Hello {0}, {0}", "foo")
                 if (!(stringFormatArgument instanceof J.NewArray) && originalIndices.size() > 1) {
-                    return updatedMi.withArguments(ListUtils.concatAll(updatedMi.getArguments(), Collections.nCopies(originalIndices.size() - 1, updatedStringFormatArgument)));
+                    return updatedMi.withArguments(ListUtils.concatAll(updatedMi.getArguments(), nCopies(originalIndices.size() - 1, updatedStringFormatArgument)));
                 }
                 // Delegate to ArgumentArrayToVarargs to convert the array argument to varargs
                 doAfterVisit(new ArgumentArrayToVarargs().getVisitor());

src/main/resources/META-INF/rewrite/examples.yml

@@ -91,6 +91,29 @@ examples:
     language: java
 ---
 type: specs.openrewrite.org/v1beta/example
+recipeName: org.openrewrite.java.logging.ArgumentArrayToVarargs
+examples:
+- description: ''
+  sources:
+  - before: |
+      import org.slf4j.Logger;
+      class Test {
+          Logger logger;
+          void method() {
+              logger.info("Message {} {} {}", new Object[]{"old", "style", "args"});
+          }
+      }
+    after: |
+      import org.slf4j.Logger;
+      class Test {
+          Logger logger;
+          void method() {
+              logger.info("Message {} {} {}", "old", "style", "args");
+          }
+      }
+    language: java
+---
+type: specs.openrewrite.org/v1beta/example
 recipeName: org.openrewrite.java.logging.CatchBlockLogLevel
 examples:
 - description: ''
@@ -284,6 +307,58 @@ examples:
     language: java
 ---
 type: specs.openrewrite.org/v1beta/example
+recipeName: org.openrewrite.java.logging.jboss.FormattedArgumentsToVMethodRecipes
+examples:
+- description: ''
+  sources:
+  - before: |
+      import org.jboss.logging.Logger;
+
+      class Test {
+          void test(Logger logger, String msg, Throwable t, Object[] formatArgs, Object o) {
+              logger.info(msg, formatArgs);
+              logger.info(msg, new Object[]{o});
+              logger.info((Object)msg, formatArgs, t);
+              logger.info(o, formatArgs, t);
+          }
+      }
+    after: |
+      import org.jboss.logging.Logger;
+
+      class Test {
+          void test(Logger logger, String msg, Throwable t, Object[] formatArgs, Object o) {
+              logger.infov(msg, formatArgs);
+              logger.infov(msg, new Object[]{o});
+              logger.infov(msg, formatArgs, t);
+              logger.info(o, formatArgs, t);
+          }
+      }
+    language: java
+---
+type: specs.openrewrite.org/v1beta/example
+recipeName: org.openrewrite.java.logging.jboss.JBossLoggingBestPractices
+examples:
+- description: ''
+  sources:
+  - before: |
+      import org.jboss.logging.Logger;
+
+      class Test {
+          void test(Logger logger, String msg, Object o) {
+              logger.info(msg, new Object[]{o});
+          }
+      }
+    after: |
+      import org.jboss.logging.Logger;
+
+      class Test {
+          void test(Logger logger, String msg, Object o) {
+              logger.infov(msg, o);
+          }
+      }
+    language: java
+---
+type: specs.openrewrite.org/v1beta/example
 recipeName: org.openrewrite.java.logging.jul.LoggerLevelArgumentToMethodRecipes
 examples:
 - description: ''